Skip to content

Rust download failure not caught during local builds #1941

@mistydemeo

Description

@mistydemeo

It looks like we're missing the pipefail setting on local builds, so if the curl download to install rustup fails, we never notice and just pipe an empty string into sh without realizing anything went wrong. Seen here: https://github.com/axodotdev/cargo-dist/actions/runs/16460730880/job/46527318893?pr=1940#step:5:1

if ! command -v cargo > /dev/null 2>&1; then
  curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs/ | sh -s -- -y
  echo "$HOME/.cargo/bin" >> $GITHUB_PATH
fi
curl: (7) Couldn't connect to server

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions