IGNITE-28308 Remove Serializable from discovery custom messages (#13001)

Author: NSAmelchev

modules/core/src/main/java/org/apache/ignite/internal/managers/discovery/SecurityAwareCustomMessageWrapper.java

@@ -30,9 +30,6 @@
 
 /** Custom message wrapper with ID of security subject that initiated the current message. */
 public class SecurityAwareCustomMessageWrapper implements DiscoverySpiCustomMessage, MarshallableMessage {
-    /** */
-    private static final long serialVersionUID = 0L;
-
     /** Security subject ID. */
     @Order(0)
     UUID secSubjId;
@@ -93,7 +90,6 @@ public DiscoveryCustomMessage delegate() {
         return ack == null ? null : new SecurityAwareCustomMessageWrapper(ack, secSubjId);
     }
 
-
     /** {@inheritDoc} */
     @Override public void prepareMarshal(Marshaller marsh) throws IgniteCheckedException {
         if (!(delegate instanceof Message))

modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserAcceptedMessage.java

@@ -23,17 +23,13 @@
 import org.apache.ignite.internal.util.tostring.GridToStringInclude;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.plugin.extensions.communication.Message;
 import org.jetbrains.annotations.Nullable;
 
 /**
  * Is sent as an acknowledgement for end (with success or error) of user management operation on the cluster
  * (see {@link UserProposedMessage} and {@link UserManagementOperation}).
  */
-public class UserAcceptedMessage implements DiscoveryCustomMessage, Message {
-    /** */
-    private static final long serialVersionUID = 0L;
-
+public class UserAcceptedMessage implements DiscoveryCustomMessage {
     /** */
     @Order(0)
     IgniteUuid id;
@@ -95,5 +91,4 @@ Throwable error() {
     @Override public String toString() {
         return S.toString(UserAcceptedMessage.class, this);
     }
-
 }

modules/core/src/main/java/org/apache/ignite/internal/processors/authentication/UserProposedMessage.java

@@ -23,7 +23,6 @@
 import org.apache.ignite.internal.util.tostring.GridToStringInclude;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.plugin.extensions.communication.Message;
 import org.jetbrains.annotations.Nullable;
 
 /**
@@ -33,10 +32,7 @@
  * <p>
  * {@link UserAcceptedMessage} is sent as an acknowledgement that operation is finished on the all nodes of the cluster.
  */
-public class UserProposedMessage implements DiscoveryServerOnlyCustomMessage, Message {
-    /** */
-    private static final long serialVersionUID = 0L;
-
+public class UserProposedMessage implements DiscoveryServerOnlyCustomMessage {
     /** */
     @Order(0)
     IgniteUuid id;
@@ -84,5 +80,4 @@ UserManagementOperation operation() {
     @Override public String toString() {
         return S.toString(UserProposedMessage.class, this);
     }
-
 }

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheAffinityChangeMessage.java

@@ -29,18 +29,14 @@
 import org.apache.ignite.internal.processors.cache.distributed.dht.preloader.GridDhtPartitionsFullMessage;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.plugin.extensions.communication.Message;
 import org.apache.ignite.spi.discovery.DiscoverySpiMutableCustomMessageSupport;
 import org.jetbrains.annotations.Nullable;
 
 /**
  * CacheAffinityChangeMessage represent a message that switches to a new affinity assignmentafter rebalance is finished.
  * This message should not be mutated  in any way outside the "disco-notifier-worker" thread.
  */
-public class CacheAffinityChangeMessage implements DiscoveryCustomMessage, Message {
-    /** */
-    private static final long serialVersionUID = 0L;
-
+public class CacheAffinityChangeMessage implements DiscoveryCustomMessage {
     /** */
     @Order(0)
     IgniteUuid id;

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheStatisticsClearMessage.java

@@ -23,16 +23,12 @@
 import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.plugin.extensions.communication.Message;
 import org.jetbrains.annotations.Nullable;
 
 /**
  * Cache statistics clear discovery message.
  */
-public class CacheStatisticsClearMessage implements DiscoveryCustomMessage, Message {
-    /** */
-    private static final long serialVersionUID = 0L;
-
+public class CacheStatisticsClearMessage implements DiscoveryCustomMessage {
     /** Initial message flag mask. */
     private static final byte INITIAL_MSG_MASK = 0x01;
 

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/CacheStatisticsModeChangeMessage.java

@@ -24,17 +24,13 @@
 import org.apache.ignite.internal.managers.discovery.DiscoveryCustomMessage;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.plugin.extensions.communication.Message;
 import org.apache.ignite.plugin.extensions.communication.MessageFactory;
 import org.jetbrains.annotations.Nullable;
 
 /**
  * Cache statistics mode change discovery message.
  */
-public class CacheStatisticsModeChangeMessage implements DiscoveryCustomMessage, Message {
-    /** */
-    private static final long serialVersionUID = 0L;
-
+public class CacheStatisticsModeChangeMessage implements DiscoveryCustomMessage {
     /** Initial message flag mask. */
     private static final byte INITIAL_MSG_MASK = 0x01;
 
@@ -140,5 +136,4 @@ public UUID requestId() {
     @Override public String toString() {
         return S.toString(CacheStatisticsModeChangeMessage.class, this);
     }
-
 }

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClientCacheChangeDiscoveryMessage.java

@@ -28,16 +28,12 @@
 import org.apache.ignite.internal.util.typedef.F;
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.plugin.extensions.communication.Message;
 import org.jetbrains.annotations.Nullable;
 
 /**
  * Sent from cache client node to asynchronously notify about started.closed client caches.
  */
-public class ClientCacheChangeDiscoveryMessage implements DiscoveryCustomMessage, Message {
-    /** */
-    private static final long serialVersionUID = 0L;
-
+public class ClientCacheChangeDiscoveryMessage implements DiscoveryCustomMessage {
     /** */
     @Order(0)
     IgniteUuid id;
@@ -173,7 +169,6 @@ public void updateTimeoutObject(ClientCacheUpdateTimeout updateTimeoutObj) {
         return null;
     }
 
-
     /** {@inheritDoc} */
     @Override public String toString() {
         return S.toString(ClientCacheChangeDiscoveryMessage.class, this);

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ClientCacheChangeDummyDiscoveryMessage.java

@@ -37,9 +37,6 @@
  */
 public class ClientCacheChangeDummyDiscoveryMessage extends AbstractCachePartitionExchangeWorkerTask
     implements DiscoveryCustomMessage, MarshallableMessage {
-    /** */
-    private static final long serialVersionUID = 0L;
-
     /** */
     @Order(0)
     UUID reqId;
@@ -131,7 +128,6 @@ Set<String> cachesToClose() {
             startReqs = U.unmarshal(marsh, startRequestsBytes, clsLdr);
     }
 
-
     /** {@inheritDoc} */
     @Override public String toString() {
         return S.toString(ClientCacheChangeDummyDiscoveryMessage.class, this,

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/DynamicCacheChangeBatch.java

@@ -40,9 +40,6 @@
  * Cache change batch.
  */
 public class DynamicCacheChangeBatch implements DiscoveryCustomMessage, MarshallableMessage {
-    /** */
-    private static final long serialVersionUID = 0L;
-
     /** Discovery custom message ID. */
     @Order(0)
     IgniteUuid id;
@@ -187,7 +184,6 @@ public void startCaches(boolean startCaches) {
             reqs = U.unmarshal(marsh, requestsBytes, clsLdr);
     }
 
-
     /** {@inheritDoc} */
     @Override public String toString() {
         return S.toString(DynamicCacheChangeBatch.class, this);

modules/core/src/main/java/org/apache/ignite/internal/processors/cache/ExchangeFailureMessage.java

@@ -36,17 +36,13 @@
 import org.apache.ignite.internal.util.typedef.internal.S;
 import org.apache.ignite.internal.util.typedef.internal.U;
 import org.apache.ignite.lang.IgniteUuid;
-import org.apache.ignite.plugin.extensions.communication.Message;
 import org.apache.ignite.plugin.extensions.communication.MessageFactory;
 import org.jetbrains.annotations.Nullable;
 
 /**
  * This class represents discovery message that is used to provide information about dynamic cache start failure.
  */
-public class ExchangeFailureMessage implements DiscoveryCustomMessage, Message {
-    /** */
-    private static final long serialVersionUID = 0L;
-
+public class ExchangeFailureMessage implements DiscoveryCustomMessage {
     /** Cache names. */
     @GridToStringInclude
     @Order(0)
@@ -66,7 +62,7 @@ public class ExchangeFailureMessage implements DiscoveryCustomMessage, Message {
     Map<UUID, ErrorMessage> exchangeErrors;
 
     /** Actions to be done to rollback changes done before the exchange failure. */
-    private transient ExchangeActions exchangeRollbackActions;
+    private ExchangeActions exchangeRollbackActions;
 
     /** Default constructor for {@link MessageFactory}. */
     public ExchangeFailureMessage() {