Skip to content

Commit 6c2bf2f

Browse files
committed
IGNITE-27947 Apply code-reviews
** Fixed type ** Updated javadoc comment on ClientInboundMessageHandler ** Added IGNITE-28405 ticket mention
1 parent f649f76 commit 6c2bf2f

File tree

3 files changed

+3
-4
lines changed

3 files changed

+3
-4
lines changed

modules/client-handler/src/main/java/org/apache/ignite/client/handler/ClientInboundMessageHandler.java

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -306,8 +306,7 @@ public class ClientInboundMessageHandler
306306
*
307307
* <p><b>Mappings are removed:</b>
308308
* <ul>
309-
* <li>During a rollback request.</li>
310-
* <li>After the first request response is sent to the client.</li>
309+
* <li>During a commit or rollback request. Hook is added at creation.</li>
311310
* </ul>
312311
*/
313312
private final Map<Long, Long> firstReqToTxResMap = new ConcurrentHashMap<>();

modules/client-handler/src/main/java/org/apache/ignite/client/handler/requests/table/DirectTransactionWithFirstRequest.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@
3232
class DirectTransactionWithFirstRequest implements InternalTransaction, Wrapper {
3333
private final InternalTransaction base;
3434

35-
// We could alos just accept a lambda.
35+
// We could also just accept a lambda.
3636
private final Map<Long, Long> reqToTxMap;
3737

3838
private final long firstReqId;

modules/client/src/main/java/org/apache/ignite/internal/client/tx/ClientLazyTransaction.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ public void rollback() throws TransactionException {
100100
public CompletableFuture<Void> rollbackAsync() {
101101
var tx0 = tx;
102102

103-
// This is really fishy. It will probably let you reuse a transaction after calling a rollback :(
103+
// TODO: IGNITE-28405 This is really fishy. It will probably let you reuse a transaction after calling a rollback :(
104104
if (tx0 == null) {
105105
// No operations were performed, nothing to rollback.
106106
return nullCompletedFuture();

0 commit comments

Comments
 (0)