Skip to content
This repository was archived by the owner on Mar 12, 2026. It is now read-only.

Commit ee70ab4

Browse files
authored
fix: bug about logging nothing (#1250)
## Rationale Bug leading to logging nothing is introduced by pr #1235 , I fix it in this pr by overwritting `tag` default value to empty. ## Detailed Changes + Hide all detailed impl about logging in `logger` crate. + Overwrite default `tag` value(set by `log` crate) to empty. ## Test Plan Test manually.
1 parent 2acc473 commit ee70ab4

File tree

143 files changed

+221
-176
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

143 files changed

+221
-176
lines changed

Cargo.lock

Lines changed: 21 additions & 25 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -114,7 +114,6 @@ hash_ext = { path = "components/hash_ext" }
114114
hex = "0.4.3"
115115
lz4_flex = { version = "0.11", default-features = false, features = ["frame"] }
116116
lazy_static = "1.4.0"
117-
log = "0.4"
118117
logger = { path = "components/logger" }
119118
lru = "0.7.6"
120119
id_allocator = { path = "components/id_allocator" }

analytic_engine/Cargo.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ generic_error = { workspace = true }
4747
hex = { workspace = true }
4848
id_allocator = { workspace = true }
4949
lazy_static = { workspace = true }
50-
log = { workspace = true }
50+
logger = { workspace = true }
5151
lru = { workspace = true }
5252
macros = { workspace = true }
5353
message_queue = { workspace = true }

analytic_engine/src/compaction/picker.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ use std::{
2121
};
2222

2323
use common_types::time::Timestamp;
24-
use log::{debug, info};
24+
use logger::{debug, info};
2525
use macros::define_result;
2626
use snafu::Snafu;
2727
use time_ext::TimeUnit;

analytic_engine/src/compaction/scheduler.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ use std::{
2727
use async_trait::async_trait;
2828
use common_types::request_id::RequestId;
2929
use futures::{stream::FuturesUnordered, StreamExt};
30-
use log::{debug, error, info, warn};
30+
use logger::{debug, error, info, warn};
3131
use macros::define_result;
3232
use runtime::{JoinHandle, Runtime};
3333
use serde::{Deserialize, Serialize};

analytic_engine/src/engine.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ use std::sync::Arc;
1818

1919
use async_trait::async_trait;
2020
use generic_error::BoxError;
21-
use log::{error, info};
21+
use logger::{error, info};
2222
use snafu::{OptionExt, ResultExt};
2323
use table_engine::{
2424
engine::{

analytic_engine/src/instance/alter.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
use std::collections::HashMap;
1818

1919
use generic_error::BoxError;
20-
use log::info;
20+
use logger::info;
2121
use snafu::{ensure, ResultExt};
2222
use table_engine::table::AlterSchemaRequest;
2323
use wal::{kv_encoder::LogBatchEncoder, manager::WriteContext};

analytic_engine/src/instance/close.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
//! Close table logic of instance
1616
17-
use log::{info, warn};
17+
use logger::{info, warn};
1818
use snafu::ResultExt;
1919
use table_engine::engine::CloseTableRequest;
2020

analytic_engine/src/instance/create.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
//! Create table logic of instance
1616
1717
use generic_error::BoxError;
18-
use log::info;
18+
use logger::info;
1919
use snafu::{ensure, OptionExt, ResultExt};
2020
use table_engine::{
2121
engine::{CreateTableParams, CreateTableRequest},

analytic_engine/src/instance/drop.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@
1414

1515
//! Drop table logic of instance
1616
17-
use log::{info, warn};
17+
use logger::{info, warn};
1818
use snafu::ResultExt;
1919
use table_engine::engine::DropTableRequest;
2020

0 commit comments

Comments
 (0)