Added clang-tidy and Fixed Lints (#2)

* Added clang-tidy and fixed lints

Author: adambcomer

.clang-tidy

@@ -0,0 +1,3 @@
+Checks: 'clang-diagnostic-*,clang-analyzer-*,-clang-analyzer-security.insecureAPI.DeprecatedOrUnsafeBufferHandling'
+WarningsAsErrors: '*'
+FormatStyle: mozilla

.github/workflows/meson.yml

@@ -25,6 +25,9 @@ jobs:
     - name: Clang-Format Check 
       run: make format.check 
 
+    - name: Clang-Tidy Check 
+      run: make lint.check 
+
     - name: Build
       run: make build 
 

Makefile

@@ -1,4 +1,4 @@
-.PHONY: init init.release build test format format.check docs docs.deploy clean
+.PHONY: init init.release build test format format.check lint lint.check docs docs.deploy clean
 init:
 	meson setup build --warnlevel=2 --wipe --werror
 
@@ -17,6 +17,12 @@ format:
 format.check:
 	ninja -C build clang-format-check
 
+lint:
+	ninja -C build clang-tidy-fix
+
+lint.check:
+	ninja -C build clang-tidy
+
 docs:
 	doxygen 
 

src/sstable.c

@@ -161,6 +161,7 @@ SSTable_new(char* path)
     size_t file_res = fread(&key_len, sizeof(uint64_t), 1, table->file);
     if (file_res != 1) {
       perror("fread");
+      free(table);
       return NULL;
     }
 
@@ -169,6 +170,7 @@ SSTable_new(char* path)
     file_res = fseeko(table->file, (long long)next, SEEK_CUR);
     if (file_res != 0) {
       perror("fread");
+      free(table);
       return NULL;
     }
 
@@ -177,30 +179,38 @@ SSTable_new(char* path)
     curr_offset += next + sizeof(uint64_t);
   }
 
-  int seek_res = fseeko(table->file, (long long)table->records[0], SEEK_SET);
+  int seek_res = fseeko( // NOLINT(clang-analyzer-core.CallAndMessage)
+    table->file,
+    (long long)table->records[0],
+    SEEK_SET);
   if (seek_res == -1) {
     perror("fseeko");
+    free(table);
     return NULL;
   }
 
   uint64_t low_key_len;
   size_t file_res = fread(&low_key_len, sizeof(uint64_t), 1, table->file);
   if (file_res != 1) {
     perror("fread");
+    free(table);
     return NULL;
   }
 
   uint64_t val_loc;
   file_res = fread(&val_loc, sizeof(int64_t), 1, table->file);
   if (file_res != 1) {
     perror("fread");
+    free(table);
     return NULL;
   }
 
   char* low_key = malloc(low_key_len);
   file_res = fread(low_key, sizeof(char), low_key_len, table->file);
   if (file_res != low_key_len) {
     perror("fread");
+    free(table);
+    free(low_key);
     return NULL;
   }
 
@@ -211,26 +221,35 @@ SSTable_new(char* path)
     fseeko(table->file, (long long)table->records[table->size - 1], SEEK_SET);
   if (seek_res == -1) {
     perror("fseeko");
+    free(table);
+    free(low_key);
     return NULL;
   }
 
   uint64_t high_key_len;
   file_res = fread(&high_key_len, sizeof(uint64_t), 1, table->file);
   if (file_res != 1) {
     perror("fread");
+    free(table);
+    free(low_key);
     return NULL;
   }
 
   file_res = fread(&val_loc, sizeof(int64_t), 1, table->file);
   if (file_res != 1) {
     perror("fread");
+    free(table);
+    free(low_key);
     return NULL;
   }
 
   char* high_key = malloc(high_key_len);
   file_res = fread(high_key, sizeof(char), high_key_len, table->file);
   if (file_res != high_key_len) {
     perror("fread");
+    free(table);
+    free(low_key);
+    free(high_key);
     return NULL;
   }
 
@@ -308,7 +327,11 @@ SSTable_get_value_loc(struct SSTable* table, char* key, size_t key_len)
     int m = a + (b - a) / 2;
 
     struct SSTableRecord record;
-    SSTableRecord_read(table, &record, table->records[m]);
+    int res = SSTableRecord_read(table, &record, table->records[m]);
+    if (res == -1) {
+      perror("Error reading record from SSTable");
+      return -1;
+    }
 
     int cmp = SSTable_key_cmp(&record, key, key_len);
     free(record.key);