You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The release from v3.17.0 to v3.17.4 contains a mix of valuable updates and significant slop. While there are numerous GOOD commits addressing concrete issues, improving functionality, and enhancing documentation, the slop ratio exceeds 15% due to administrative noise, minor refactor churn, and some unclear refactors. Dependency changes are mostly version bumps without conflicts indicated. No breaking changes or critical architecture drift were identified, but careful selection of GOOD commits is advised.
Batch classification
Verdict
Count
Branch
🟢 GOOD
87
sync/upstream/v3.17.4-good
🟡 NEEDS_REVIEW
3
sync/upstream/v3.17.4-needs-review
🔴 SLOP
26
sync/upstream/v3.17.4-slop
🟢 Good batch
Classified as real value. Candidate for merge.
ad85e438fix: include user/project agents in task(subagent_type) resolution -- The commit fixes a concrete behavior issue by including user and project agents in task resolution, with clear tests covering various scenarios.
2266f28ffix: correct merge order so project agents override user agents -- The commit fixes a concrete behavior issue by ensuring project agents override user agents when names collide, with a new test covering this scenario.
64408823fix: actually swap merge order so project is added before user -- The commit fixes a concrete behavior issue by swapping the merge order of project and user agents, ensuring project agents take precedence, with a new test covering this scenario.
5441c848refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replaces vi.mock with spyOn for agent loader mocks, which is a clear refactor with idiomatic value for bun:test as suggested in a PR review, improving test setup clarity.
b0b19f30fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- Fixes concrete behavior issues with Windows path handling and CRLF line endings in grep tool output parsing.
e9b6bba1refactor(agent-display): centralize name normalization resolution -- The commit centralizes name normalization for agent displays, adds tests for legacy name conversion and prefix stripping, and simplifies the resolution logic with clear functional benefits.
f95e7a6crefactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse a shared gateway URL validation function, removing redundant code and improving maintainability.
40411f32docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- Added substantial documentation for multiple agents and built-in skills, providing clear overviews, file structures, and key behaviors.
21822ba2test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs.
a2ae3de3refactor(openclaw): extract gateway url validator -- Extracted a reusable function validateGatewayUrl, removing redundancy and improving maintainability.
69f1c9aefix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear fix for a specific reliability issue.
314e1a5efix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, adding clear geographic analytics value.
d21ed3f7fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear fix for a specific reliability issue.
565d3ffafix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin-* platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a known problem with macOS Gatekeeper rejecting unsigned binaries.
71b5ab67fix(ci): replace breaking codesign step with signature verification -- The commit fixes a concrete CI issue by replacing a breaking codesign step with signature verification for macOS binaries, directly addressing a known problem.
16e7fa5bfix(ci): ad-hoc sign darwin binaries with plain codesign -- Explicitly signs Darwin binaries with 'codesign' to address CI issue with unsigned binaries on macOS runners.
470ed8b1fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a known problem with codesign.
2d65896brefactor(shared): simplify normalize SDK null guards -- Simplified null checks in normalizeSDKResponse function with clear, defensible value by replacing explicit null and undefined checks with the more concise '== null' syntax, improving readability without altering functionality.
cd8352c1refactor(claude-code-mcp-loader): simplify env expansion null guard -- Simplified null checks in a function with clear readability improvement without altering functionality.
50df6f0dtest(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.
668bc8e8refactor(config-manager): simplify config parsing guards -- The commit simplifies redundant conditional logic in addPluginToOpenCodeConfig and adds meaningful test coverage for config parsing errors in parse-opencode-config-file.test.ts.
a0d5131erefactor(plugin): remove dead chat params code -- Removed dead code (unused 'variant' and 'normalizeSDKResponse' import) with clear maintenance benefit
21cad26cdocs(config): remove redundant schema default comments -- Removed redundant default value comments in schema definitions, improving documentation clarity without altering functionality.
4de02094test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent output for null and undefined inputs.
c750781bfix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- Fixes a concrete behavior issue by adjusting regex to exclude npm scoped packages, with clear necessity and direct impact on functionality.
2d8b4a9dfix(anthropic-effort): skip effort injection for github-copilot provider ([Bug]: code-yeongyu/oh-my-openagent#3270) -- Explicit guard added to skip effort injection for github-copilot provider, preserving native Anthropic support, with clear necessity and direct impact on functionality.
3d2eb6e4fix(config): preserve explicit git_master overrides during merge -- Adds tests and logic to preserve explicit git_master overrides, addressing a concrete configuration behavior issue with clear necessity and direct impact on functionality.
dac0c99efeat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration and fallback logic, enabling users to use it as a universal fallback for multiple models.
aac17135test: add vercel provider transform tests -- Adds meaningful test coverage for Vercel provider transformations with multiple scenarios
6f72ec75test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with specific scenarios and assertions, increasing test coverage for a real feature.
542dc890fix(provider): use gateway-specific model IDs for vercel transform -- Fixes model ID transformation for Vercel AI Gateway by removing '-preview' suffix as per gateway's requirements, with direct impact on functionality.
34e334eafeat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel provider fallback entries with clear integration and fallback logic, enabling users to use it as a universal fallback for multiple models.
effae16crefactor(provider): replace per-model string replacements with generic regex -- Replaces multiple per-model string replacements with a generic regex, simplifying the code and making it more maintainable and scalable for new models.
680d05a2Prometheus: keep planner primary-only -- Changes Prometheus agent mode from 'all' to 'primary' across multiple tests and config builders, aligning with the stated goal of keeping the planner primary-only, with clear functional impact.
e3b5c2befix: address review feedback for Vercel AI Gateway PR -- Adds a new CLI option for Vercel AI Gateway, updates priority logic for native providers, and fixes test expectations for model ID format, all of which provide clear functional improvements and user value.
01a1b141fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a concrete behavior fix by rejecting primary agents in task subagent resolution, with clear functional impact and user value through new functions and logic in multiple files.
3673b962docs(readme-ru): add telemetry and legal section translation -- Added meaningful Russian translations for telemetry and legal sections in README.ru.md with clear user value and functional information.
23d0a0dcdocs(readme-zh-cn): add telemetry and legal section translation -- Added meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md with clear user value and functional information.
0ece66e3docs(readme-ja): add telemetry and legal section translation -- Added meaningful Japanese translations for telemetry and legal sections in README.ja.md with clear user value and functional information.
12ed9501docs(readme-ko): add telemetry and legal section translation -- Added meaningful Korean translations for telemetry and legal sections in README.ko.md with clear user value and functional information.
c91db2ebdocs(cli): add --vercel-ai-gateway flag documentation -- Added documentation for a new CLI flag --vercel-ai-gateway with clear description and default value, providing user value.
e223ab20docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the list of available agents in the configuration documentation, providing clear user value by informing users of an additional option.
9342e55bdocs(installation): replace npx with bunx and update provider flags -- Updated installation docs to reflect 'bunx' usage and added relevant provider flags with clear user value
05e54444docs(overview): update model-role claims and complete category list -- The commit updates the documentation to include a complete and detailed category list for model roles, enhancing user understanding and configuration clarity.
7c94ee45docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in documentation to match current source of truth in src/shared/model-requirements.ts, improving accuracy for users.
b57a7975docs(ollama): verify troubleshooting steps and issue links -- Updated troubleshooting steps with verified issue links and clear documentation improvements for user value.
bbbd1bd0docs(orchestration): update diagram model names and category tables -- Updated documentation with clear, substantive changes to model names, category tables, and fallback chains, enhancing user understanding and configuration clarity.
4ce1dde3CLI: isolate provider model id transforms from shared mocks -- Added multiple tests for provider model ID transformations across various providers (github-copilot, google, anthropic, vercel) with clear expected outputs, significantly increasing test coverage for real scenarios.
1b36194bfix(cli): treat missing session status as idle in run completion -- Added a test case to handle missing session status as idle, preventing potential hangs, and updated logic in poll-for-completion.ts to return 'idle' when the session ID is missing from statuses.
b5250555fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure scenarios, ensuring no-throw behavior for clients.
62c60ae9fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs with clear functional impact, including handling numeric skill names, adding a required parameter for task() examples, and stripping ZWSP characters for agent name comparisons.
76c5356atest(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases covering various scenarios.
da91c535fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds requirement-based tests, and improves agent resolution logic with clear functional impact.
1e85a88dfix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, directly impacting functionality with clear behavioral change.
fd28f7e6feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with comprehensive test suite and clear functional value
5755a90cfeat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with multiple file format support, comprehensive tests, and clear functional value.
39bda91bfeat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain, adds filtering logic, and includes 7 new integration tests, demonstrating clear functional value and thorough testing.
3d0fb22cfix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit fixes a concrete compatibility issue by replacing outdated mockCtx references with the new createMockCtx factory in four test cases, ensuring tests work with the updated codebase.
42445f51fix(agents): address cubic review findings on agent loader -- The commit addresses specific cubic review findings with concrete behavior fixes, including case-insensitive file extension handling, relative path resolution, and precedence logic adjustments, all backed by new tests.
cf4b2315fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaces 'in' with Object.hasOwn() for prototype-safe property checks in opencode-config-agents-reader.ts, addressing a specific issue with inherited properties.
4c77045cfix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by preventing proto pollution using a null-prototype accumulator, addressing a specific vulnerability with clear functional impact.
ab11f2ebfix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test state pollution, ensuring downstream tests run cleanly.
47aa3025fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by replacing outdated mockCtx references with the new createMockCtx factory in four test cases, ensuring tests work with the updated codebase.
0764526afix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture in posthog to stay within the free tier limit, preserving manual capture for critical errors.
a1842f2dfeat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip persistence, case insensitivity, and edge cases like missing or blank call IDs.
80d3339cfeat(background-agent): add wait-for-task-session helper -- Adds a meaningful waitForTaskSessionID helper with thorough test coverage for various scenarios, including immediate resolution, polling, abort signals, and timeouts, clearly enhancing functionality with real value.
4da30057fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with clear test coverage and functional impact.
c6a407c4refactor(tools): migrate producers to shared metadata bridge -- The commit refactors multiple files to migrate producers to a shared metadata bridge, replacing storeToolMetadata with publishToolMetadata across various task handlers, indicating a clear architectural improvement with broad impact.
Branch: sync/upstream/v3.17.4-good (local only; not on origin)
⚠️ 6 commit(s) failed to cherry-pick and are NOT in the draft PR.
🚫 Push to origin was rejected. GITHUB_TOKEN cannot create or modify files under .github/workflows/. The batch branch exists only in the workflow runner and was discarded. To merge this batch, run the analyzer with a PAT that has the workflow scope, or cherry-pick locally.
📝 4 commit(s) touch .github/workflows/ and require elevated permissions to sync: 565d3ff, 71b5ab6, 16e7fa5, 470ed8b
🟡 Review batch
Ambiguous. Human should review before merging.
79a475d6refactor(background-agent): simplify loop detector null guard -- Classification failed: No object generated: response did not match schema.
141798efrefactor(background-agent): standardize loop detector null guards -- Classification failed: No object generated: response did not match schema.
569addd3docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.
Branch: sync/upstream/v3.17.4-needs-review (on origin)
⚠️ 1 commit(s) failed to cherry-pick and are NOT in the draft PR.
🔴 Slop batch
Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.
1e2e0019refactor(create-tools): keep result type internal -- The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit, fitting the 'minor_visibility_churn' category with no apparent payoff.
9d89bbb0refactor(commands): keep builtin command options internal -- Changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit.
0c5cd3a1chore(agents): update all AGENTS.md generation dates to 2026-04-11 -- The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn.
6713b30crefactor(hooks): drop no-op directory injector callbacks -- Removed no-op callbacks without adding new functionality or improving existing code structure in a meaningful way.
678011c7docs(contributing): update tool/hook counts and version references -- The commit updates tool/hook counts and version references in the CONTRIBUTING.md file, which appears to be metadata churn with no addition of new substantive information or functional value.
cfd152addocs(features): update agent count and verify category list -- Added two new agent descriptions with overly generic and vague capabilities, lacking concrete examples or clear user value beyond buzzwords.
0cb0a6c0docs(contributing): update tool/hook counts and version references -- The commit updates tool/hook counts in CONTRIBUTING.md, which is metadata churn with no addition of new substantive information or functional value.
fe091ef2chore: bump version to 3.17.4 -- The commit only updates the version number in package.json with no functional changes.
c9350c67release: v3.17.4 -- The commit only updates version numbers in multiple package.json files with no functional changes, indicating administrative noise.
Branch: sync/upstream/v3.17.4-slop (on origin)
Slop verifier second-pass notes
1e2e001 CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of CreateToolsResult from export to internal without any clear functional or architectural benefit. This fits the 'minor_visibility_churn' category with no apparent payoff, as the type is still defined identically but now less accessible. There's no concrete behavior delta, no new abstractions with multiple callers, and the commit message lacks justification for the change. A senior engineer would likely question the value of this change in a code review.
9d89bbb CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility of LoadBuiltinCommandsOptions from export to internal without clear functional or architectural benefit, aligning with minor_visibility_churn. No runtime behavior changes, and the interface's usage scope isn't broadened beyond its current single caller context. The change lacks a concrete justification or impact on the system's behavior, invariants, or user experience.
0c5cd3a CONFIRMED_SLOP (behavior delta: none): The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn, which aligns with the 'date_count_metadata_churn' slop signal. There is no concrete behavior delta, and the change does not introduce new functionality or improve existing code in a measurable way.
e654cfb CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.
6713b30 CONFIRMED_SLOP (behavior delta: none): The commit removes no-op callbacks without adding new functionality or improving existing code structure in a meaningful way. The changes are purely refactor_churn and removed unused code without clear benefit, aligning with documented slop patterns. No concrete behavior delta or user-visible changes are introduced.
6a0d515 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.
5b33cd2 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass reason correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or improvements.
c6deb6d CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the codebase.
42df1c3 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.
84f980c CONFIRMED_SLOP (behavior delta: none): The commit adds only a CLA signature to cla.json, which is purely administrative with no impact on code or product functionality. This aligns with the 'cla_admin' slop signal and does not provide any measurable value to the repository's functionality or user experience.
678011c CONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in a documentation file without adding substantive new information or functional value. The changes are metadata updates and do not alter any runtime behavior, user-visible output, or invariants. The commit message accurately reflects the changes but does not justify the addition of real value beyond churn.
cfd152a CONFIRMED_SLOP (behavior delta: none): The commit adds two new agent descriptions with overly generic and vague capabilities, lacking concrete examples or clear user value beyond buzzwords. The commit message uses vague 'update' without a concrete behavior delta. The changes expand existing docs without adding new facts, aligning with documented slop patterns.
0cb0a6c CONFIRMED_SLOP (behavior delta: none): The commit updates counts in a documentation file without adding new substantive information or functional value. This aligns with metadata churn, a documented slop pattern. No runtime behavior changes, and the update does not introduce new facts or capabilities beyond bookkeeping.
3419bbc CONFIRMED_SLOP (behavior delta: none): The commit only updates a CLA signature JSON file with a new contributor's information, which is administrative in nature and does not add any code or product value. This aligns with the 'cla_admin' slop signal and does not meet the criteria for a GOOD commit as per the given rubric.
1bb59c3 CONFIRMED_SLOP (behavior delta: none): The commit is a release version bump with no code changes, only updating version numbers in multiple package.json files. This matches the 'release_version_bump' slop pattern, and according to the verification bias, such commits should not be demoted to GOOD. There is no concrete behavior delta, and the change is purely administrative.
571cf1f CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise without direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.
f98f7ec CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.
d97c067 CONFIRMED_SLOP (behavior delta: none): The commit only updates a CLA signature in cla.json without any code or product changes, aligning with documented slop patterns for administrative noise.
eaf5ff2 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.
f8f7ac1 CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.
54a94d4 CONFIRMED_SLOP (behavior delta: none): The commit only updates a CLA signature in cla.json without any code or product changes, aligning with 'cla_admin' slop patterns. No behavior delta exists as it's administrative noise. A senior engineer would not defend this as value-adding in a code review focused on merge value.
81a03fa CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the documented 'cla_admin' slop pattern, and there's no concrete behavior delta, abstraction, or user-visible change. A senior engineer would not defend this as value-adding in a code review focused on merge value.
9aeb87c CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the 'release_version_bump' slop pattern. No behavior delta exists as it's purely administrative. The first-pass verdict correctly identified it as SLOP.
80e73f5 CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not impact runtime code or user-visible output.
fe091ef CONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the release_version_bump slop pattern. No behavior delta exists as it's purely administrative. A senior engineer would likely not defend this as valuable in a code review focused on functional merge value.
c9350c6 CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files with no functional changes, indicating administrative noise. This aligns with the 'release_version_bump' category, which is explicitly non-GOOD by the rubric. No behavior delta exists as the changes are purely version updates.
Fork-sync impact assessment
Breaking changes
(none detected)
Dependency changes
oh-my-opencode-* package versions updated to 3.17.4
Architecture drift
(none)
Hidden concerns
Minor refactor churn without clear benefits (e.g., 1e2e001, 9d89bbb)
Verify no-op removals (6713b30) do not affect functionality
Assess the necessity of each refactor labeled as SLOP
Generated by upstream-analyzer workflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in .github/prompts/ and is editable without touching workflow code.
🟡 Upstream cost-benefit: v3.17.0 → v3.17.4
Upstream:
code-yeongyu/oh-my-openagentRecommendation:
CHERRY_PICK(confidence: medium)Slop ratio: 22%
The release from v3.17.0 to v3.17.4 contains a mix of valuable updates and significant slop. While there are numerous GOOD commits addressing concrete issues, improving functionality, and enhancing documentation, the slop ratio exceeds 15% due to administrative noise, minor refactor churn, and some unclear refactors. Dependency changes are mostly version bumps without conflicts indicated. No breaking changes or critical architecture drift were identified, but careful selection of GOOD commits is advised.
Batch classification
sync/upstream/v3.17.4-goodsync/upstream/v3.17.4-needs-reviewsync/upstream/v3.17.4-slop🟢 Good batch
Classified as real value. Candidate for merge.
ad85e438fix: include user/project agents in task(subagent_type) resolution -- The commit fixes a concrete behavior issue by including user and project agents in task resolution, with clear tests covering various scenarios.2266f28ffix: correct merge order so project agents override user agents -- The commit fixes a concrete behavior issue by ensuring project agents override user agents when names collide, with a new test covering this scenario.64408823fix: actually swap merge order so project is added before user -- The commit fixes a concrete behavior issue by swapping the merge order of project and user agents, ensuring project agents take precedence, with a new test covering this scenario.5441c848refactor: use spyOn instead of vi.mock for agent loader mocks -- The commit replaces vi.mock with spyOn for agent loader mocks, which is a clear refactor with idiomatic value for bun:test as suggested in a PR review, improving test setup clarity.b0b19f30fix(grep): handle Windows drive-letter paths and CRLF in parseOutput -- Fixes concrete behavior issues with Windows path handling and CRLF line endings in grep tool output parsing.e9b6bba1refactor(agent-display): centralize name normalization resolution -- The commit centralizes name normalization for agent displays, adds tests for legacy name conversion and prefix stripping, and simplifies the resolution logic with clear functional benefits.f95e7a6crefactor(openclaw): reuse shared gateway url validation -- The commit refactors the code to reuse a shared gateway URL validation function, removing redundant code and improving maintainability.40411f32docs(agents): add AGENTS.md documentation for prometheus, hephaestus, sisyphus variants, and builtin-skills -- Added substantial documentation for multiple agents and built-in skills, providing clear overviews, file structures, and key behaviors.21822ba2test(openclaw): cover shared gateway url validation -- Adds meaningful test coverage for gateway URL validation scenarios, including HTTPS, local HTTP, and invalid URLs.a2ae3de3refactor(openclaw): extract gateway url validator -- Extracted a reusable function validateGatewayUrl, removing redundancy and improving maintainability.69f1c9aefix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear fix for a specific reliability issue.314e1a5efix(telemetry): enable GeoIP resolution for PostHog events -- Explicitly enables GeoIP resolution for PostHog events by setting disableGeoip to false, adding clear geographic analytics value.d21ed3f7fix(doctor): add timeouts to subprocess spawns to prevent exit code 137 -- Adds timeouts to subprocess spawns to prevent hanging processes and SIGKILL (exit code 137), introducing a clear fix for a specific reliability issue.565d3ffafix(ci): build darwin binaries on macOS runners to restore code signing -- The commit fixes a concrete CI issue by routing darwin-* platforms to macOS runners for native compilation and adds an explicit ad-hoc codesign step to restore code signing, directly addressing a known problem with macOS Gatekeeper rejecting unsigned binaries.71b5ab67fix(ci): replace breaking codesign step with signature verification -- The commit fixes a concrete CI issue by replacing a breaking codesign step with signature verification for macOS binaries, directly addressing a known problem.16e7fa5bfix(ci): ad-hoc sign darwin binaries with plain codesign -- Explicitly signs Darwin binaries with 'codesign' to address CI issue with unsigned binaries on macOS runners.470ed8b1fix(ci): remove existing signature before ad-hoc signing darwin binary -- The commit fixes a concrete CI issue by removing an existing malformed signature before applying a fresh ad-hoc signature to Darwin binaries, directly addressing a known problem with codesign.2d65896brefactor(shared): simplify normalize SDK null guards -- Simplified null checks in normalizeSDKResponse function with clear, defensible value by replacing explicit null and undefined checks with the more concise '== null' syntax, improving readability without altering functionality.cd8352c1refactor(claude-code-mcp-loader): simplify env expansion null guard -- Simplified null checks in a function with clear readability improvement without altering functionality.50df6f0dtest(claude-code-plugin-loader): cover plugin path nullish resolution -- Adds meaningful test coverage for plugin path resolution, including nullish input handling.668bc8e8refactor(config-manager): simplify config parsing guards -- The commit simplifies redundant conditional logic inaddPluginToOpenCodeConfigand adds meaningful test coverage for config parsing errors inparse-opencode-config-file.test.ts.a0d5131erefactor(plugin): remove dead chat params code -- Removed dead code (unused 'variant' and 'normalizeSDKResponse' import) with clear maintenance benefit21cad26cdocs(config): remove redundant schema default comments -- Removed redundant default value comments in schema definitions, improving documentation clarity without altering functionality.4de02094test(background-agent): lock nullish loop detector behavior -- Adds meaningful test coverage for nullish input handling in loop detector behavior, ensuring consistent output for null and undefined inputs.e71c34acfix(migration): return true when canonical config write succeeds regardless of archive status ([Bug]: v3.15.1 still inconsistently loads/migrates plugin config after rename code-yeongyu/oh-my-openagent#3133) -- Fixes a concrete behavior issue where migration incorrectly returned false due to archive failure despite successful canonical config write.7accb53cfix(shared): handle Windows rename-over-existing in write-file-atomically ([Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- Fixes a concrete behavior issue on Windows by handling rename-over-existing errors with a fallback strategy, adding meaningful test coverage for atomic file writes.9ef133a8fix(migration): register parenthesized legacy agent aliases in AGENT_NAME_MAP ([Bug]: Header 'x-opencode-agent-name' has invalid value: 'Atlas (Plan Executor)' code-yeongyu/oh-my-openagent#3281) -- Adds concrete mappings for legacy agent aliases and tests for migration correctness, addressing a specific compatibility issue.a6e4f211fix(shared): normalize claude model IDs for anthropic provider (transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- Fixes a concrete compatibility issue by normalizing model IDs for Anthropic API, with clear necessity and direct impact on functionality.4f02ace7fix(shared): guard maxOutputTokens <= 0 in model settings compatibility ([Bug]: Invalid argument for parameter maxOutputTokens: maxOutputTokens must be >= 1 code-yeongyu/oh-my-openagent#3305) -- Fixes a concrete behavior issue where invalid maxOutputTokens values (<=0) break generation by preserving user-requested maxTokens.c750781bfix(shared): avoid false-positive skill path resolution on npm scoped packages ([Bug]: Why my command run with error path? code-yeongyu/oh-my-openagent#2857) -- Fixes a concrete behavior issue by adjusting regex to exclude npm scoped packages, with clear necessity and direct impact on functionality.d7b4bec5fix(hooks,tools): replace /plan example with prometheus delegation and rename code-review example to review-work (Error message references non-existent /plan command code-yeongyu/oh-my-openagent#2633, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, [Bug]: oh-my-openagent overrides built-in tools to bypass the permission system. code-yeongyu/oh-my-openagent#2873) -- Fixes concrete behavior issues by replacing non-existent/plancommand references with Prometheus delegation guidance and renames a non-existent skill example to a real one (review-work), with added tests for missing-plan guidance.7e96af5ffix(atlas): exclude node_modules from verification git diff --stat ([Feature]: Ensure gitignore is created before starting implementation code-yeongyu/oh-my-openagent#3215) -- The commit fixes a concrete behavior issue by excluding node_modules from git diff verification, with clear necessity and direct impact on functionality.2d8b4a9dfix(anthropic-effort): skip effort injection for github-copilot provider ([Bug]: code-yeongyu/oh-my-openagent#3270) -- Explicit guard added to skip effort injection for github-copilot provider, preserving native Anthropic support, with clear necessity and direct impact on functionality.796a646cfix(non-interactive-env): use detectShellType instead of hardcoded win32 check ([Bug]: Force PowerShell env behavior in Windows code-yeongyu/oh-my-openagent#3310, Bug: PowerShell env var syntax ($env:VAR) used in bash shell on Windows code-yeongyu/oh-my-openagent#3338) -- The commit replaces a hardcoded platform check with a dynamic detectShellType() call, improving compatibility with various Windows environments (Git Bash, WSL, native PowerShell) through updated tests.64e55936fix(multimodal-looker): instruct explicit Read tool usage for PDFs (Multimodal-Looker Cannot Read PDF Files code-yeongyu/oh-my-openagent#2998) -- Explicit instruction added to ensure PDFs are loaded via the Read tool before extraction, directly addressing a functional gap.d8b9bf1afix(doctor): check comment-checker lazy-download cache path ([Question]: comment-checker not found code-yeongyu/oh-my-openagent#2911, [Bug] comment-checker hook does not trigger code-yeongyu/oh-my-openagent#3315) -- Fixes a concrete behavior issue by aligning doctor resolution order with runtime to recognize cached binaries, with clear necessity and direct impact on functionality.3bfa3bd6fix(background-agent): pass query directory to session.get in 4 call-sites ([Bug]: resolveSubagentSpawnContext fails to find project-scoped sessions — client.session.get() missing directory parameter code-yeongyu/oh-my-openagent#2937) -- The commit fixes a concrete behavior issue by passing the query directory to session.get in multiple call-sites, resolving 404 errors under newer OpenCode SDK versions.eb495793fix(event): prefer real session.idle over recent synthetic dedup ([Bug]: The model has responded normally, but there is a red alert in the input box: [TODO-DIAG] BLOCKED: no todossession.idle event code-yeongyu/oh-my-openagent#2667) -- The commit fixes a concrete behavior issue by ensuring real session.idle events are not dropped when a synthetic idle has fired within the dedup window, with clear necessity and direct impact on functionality.aed8dbfafix(delegate-task): fetch session result before honoring abort signal ([Bug]: @explore subagent completes but parent never returns result; 3.12.3 aborts with "The operation was aborted." code-yeongyu/oh-my-openagent#2702) -- Fixes a concrete behavior issue where the sync poller returned 'Task aborted' immediately upon abort signal, even if a terminal assistant message was available, by attempting a final fetch before emitting the abort message.c5c5bc36fix(delegate-task): consume fallback chain on sendSyncPrompt failure (delegate-task: No automatic retry with fallback models when subagent fails due to model error code-yeongyu/oh-my-openagent#2691) -- The commit fixes a concrete behavior issue by implementing a retry mechanism with a fallback chain for sendSyncPrompt failures, directly improving functionality and error handling.3d2eb6e4fix(config): preserve explicit git_master overrides during merge -- Adds tests and logic to preserve explicit git_master overrides, addressing a concrete configuration behavior issue with clear necessity and direct impact on functionality.dac0c99efeat: add Vercel AI Gateway as a provider -- Adds Vercel AI Gateway as a recognized provider with clear integration and fallback logic, enabling users to use it as a universal fallback for multiple models.aac17135test: add vercel provider transform tests -- Adds meaningful test coverage for Vercel provider transformations with multiple scenarios6f72ec75test: add integration tests for Vercel AI Gateway model resolution -- Adds integration tests for Vercel AI Gateway model resolution with specific scenarios and assertions, increasing test coverage for a real feature.542dc890fix(provider): use gateway-specific model IDs for vercel transform -- Fixes model ID transformation for Vercel AI Gateway by removing '-preview' suffix as per gateway's requirements, with direct impact on functionality.34e334eafeat(provider): add vercel to all gateway-supported fallback entries -- Adds vercel provider fallback entries with clear integration and fallback logic, enabling users to use it as a universal fallback for multiple models.effae16crefactor(provider): replace per-model string replacements with generic regex -- Replaces multiple per-model string replacements with a generic regex, simplifying the code and making it more maintainable and scalable for new models.680d05a2Prometheus: keep planner primary-only -- Changes Prometheus agent mode from 'all' to 'primary' across multiple tests and config builders, aligning with the stated goal of keeping the planner primary-only, with clear functional impact.e3b5c2befix: address review feedback for Vercel AI Gateway PR -- Adds a new CLI option for Vercel AI Gateway, updates priority logic for native providers, and fixes test expectations for model ID format, all of which provide clear functional improvements and user value.01a1b141fix(delegate-task): reject primary agents in task subagent resolution -- The commit introduces a concrete behavior fix by rejecting primary agents in task subagent resolution, with clear functional impact and user value through new functions and logic in multiple files.3673b962docs(readme-ru): add telemetry and legal section translation -- Added meaningful Russian translations for telemetry and legal sections in README.ru.md with clear user value and functional information.23d0a0dcdocs(readme-zh-cn): add telemetry and legal section translation -- Added meaningful Chinese translations for telemetry and legal sections in README.zh-cn.md with clear user value and functional information.0ece66e3docs(readme-ja): add telemetry and legal section translation -- Added meaningful Japanese translations for telemetry and legal sections in README.ja.md with clear user value and functional information.12ed9501docs(readme-ko): add telemetry and legal section translation -- Added meaningful Korean translations for telemetry and legal sections in README.ko.md with clear user value and functional information.c91db2ebdocs(cli): add --vercel-ai-gateway flag documentation -- Added documentation for a new CLI flag --vercel-ai-gateway with clear description and default value, providing user value.e223ab20docs(configuration): add sisyphus-junior to agent list -- Added a new agent 'sisyphus-junior' to the list of available agents in the configuration documentation, providing clear user value by informing users of an additional option.9342e55bdocs(installation): replace npx with bunx and update provider flags -- Updated installation docs to reflect 'bunx' usage and added relevant provider flags with clear user value05e54444docs(overview): update model-role claims and complete category list -- The commit updates the documentation to include a complete and detailed category list for model roles, enhancing user understanding and configuration clarity.7c94ee45docs(agent-model-matching): sync fallback chains with current source -- Updated fallback chains in documentation to match current source of truth in src/shared/model-requirements.ts, improving accuracy for users.b57a7975docs(ollama): verify troubleshooting steps and issue links -- Updated troubleshooting steps with verified issue links and clear documentation improvements for user value.bbbd1bd0docs(orchestration): update diagram model names and category tables -- Updated documentation with clear, substantive changes to model names, category tables, and fallback chains, enhancing user understanding and configuration clarity.4ce1dde3CLI: isolate provider model id transforms from shared mocks -- Added multiple tests for provider model ID transformations across various providers (github-copilot, google, anthropic, vercel) with clear expected outputs, significantly increasing test coverage for real scenarios.1b36194bfix(cli): treat missing session status as idle in run completion -- Added a test case to handle missing session status as idle, preventing potential hangs, and updated logic in poll-for-completion.ts to return 'idle' when the session ID is missing from statuses.b5250555fix(telemetry): guard PostHog init failures -- Adds meaningful test coverage for PostHog init failure scenarios, ensuring no-throw behavior for clients.0dab3116fix: resolve 3 bugs ([Bug]: non-interactive-env hook generates PowerShell $env: syntax on Git Bash (Windows) code-yeongyu/oh-my-openagent#3366, Agent name case change breaks Todo Continuation for historical sessions code-yeongyu/oh-my-openagent#3272, [Bug]: Using oh-my-opencode via bunx causes a new oh-my-openagent.json.bak.* backup file to be created on every OpenCode startup, even when no config changes were made. code-yeongyu/oh-my-openagent#3222) -- The commit fixes three concrete bugs with clear functional impact, including detecting Git Bash via MSYSTEM, resolving legacy agent names, and optimizing config backups.62c60ae9fix: numeric skill names, ultrawork missing run_in_background, ZWSP agent lookups -- The commit fixes concrete bugs with clear functional impact, including handling numeric skill names, adding a required parameter for task() examples, and stripping ZWSP characters for agent name comparisons.76c5356atest(agent-config): add regression tests for agent merge priority order -- Adds meaningful regression tests for agent merge priority order with clear test cases covering various scenarios.da91c535fix(call-omo-agent): address cubic review findings and add requirement-based tests -- The commit fixes concrete issues, adds requirement-based tests, and improves agent resolution logic with clear functional impact.1e85a88dfix(agent-restrictions): restore EXPLORATION_AGENT_DENYLIST as default fallback for unknown agents -- Restores a default fallback for unknown agents, directly impacting functionality with clear behavioral change.fd28f7e6feat(agents): add agent_definitions schema, eager path resolution, and JSON agent loader -- Adds agent_definitions schema, eager path resolution, and JSON agent loader with comprehensive test suite and clear functional value5755a90cfeat(agents): add agent definitions file loader and opencode.json reader -- Adds agent definitions loader with multiple file format support, comprehensive tests, and clear functional value.39bda91bfeat(agents): wire agent_definitions and opencode.json agents into precedence chain -- The commit integrates agent_definitions and opencode.json agents into the precedence chain, adds filtering logic, and includes 7 new integration tests, demonstrating clear functional value and thorough testing.3d0fb22cfix(call-omo-agent): adapt dev's model override tests to use createMockCtx factory -- The commit fixes a concrete compatibility issue by replacing outdated mockCtx references with the new createMockCtx factory in four test cases, ensuring tests work with the updated codebase.42445f51fix(agents): address cubic review findings on agent loader -- The commit addresses specific cubic review findings with concrete behavior fixes, including case-insensitive file extension handling, relative path resolution, and precedence logic adjustments, all backed by new tests.cf4b2315fix(agents): replace 'in' with Object.hasOwn() for prototype-safe property checks -- Replaces 'in' with Object.hasOwn() for prototype-safe property checks in opencode-config-agents-reader.ts, addressing a specific issue with inherited properties.4c77045cfix(agents): use null-prototype accumulator to prevent proto pollution -- The commit fixes a concrete security issue by preventing proto pollution using a null-prototype accumulator, addressing a specific vulnerability with clear functional impact.e5d3fe96fix(agents): address all PR feat(call-omo-agent): support custom agents via dynamic resolution code-yeongyu/oh-my-openagent#2299 code review findings -- The commit addresses multiple code review findings with concrete behavior fixes, refactorings, and test additions, demonstrating clear functional and maintenance value.ab11f2ebfix(tests): replace mock.module with spyOn to prevent test pollution -- Replaced mock.module() with spyOn() to prevent test state pollution, ensuring downstream tests run cleanly.e1b2f97bfix: isPlanFamily regression tests, code-review -> review-work in test data (bug: isPlanFamily() substring matching false-positives Atlas/Metis/Momus display names code-yeongyu/oh-my-openagent#3312, [Bug]: Skill tool schema uses non-existent "code-review" as example instead of actual "review-work" skill code-yeongyu/oh-my-openagent#3285, transformModelForProvider missing anthropic provider — dash-format model IDs rejected by OpenCode code-yeongyu/oh-my-openagent#3290) -- The commit fixes regression tests by updating 'code-review' to 'review-work' in test data and adds specific tests to ensure 'isPlanFamily' correctly handles false positives and edge cases.47aa3025fix(cli): use getAgentRuntimeName for agent resolution in run command -- The commit fixes a concrete behavior issue by replacing outdated mockCtx references with the new createMockCtx factory in four test cases, ensuring tests work with the updated codebase.0764526afix(posthog): disable exception autocapture to stay within free tier -- Disables exception autocapture in posthog to stay within the free tier limit, preserving manual capture for critical errors.ccb2715afix: hide native plan agent when replace_plan is true ([Bug]: Native plan agent not hidden when replace_plan is true - Sisyphus routes to it instead of Prometheus code-yeongyu/oh-my-openagent#3443) -- The commit fixes a concrete behavior issue by hiding the native plan agent when replace_plan is true, preventing incorrect routing to the native plan agent instead of Prometheus, with clear functional impact.a1842f2dfeat(tool-metadata): add shared metadata contract and bridge -- Adds a shared metadata contract and bridge with meaningful tests covering various scenarios, including round-trip persistence, case insensitivity, and edge cases like missing or blank call IDs.80d3339cfeat(background-agent): add wait-for-task-session helper -- Adds a meaningfulwaitForTaskSessionIDhelper with thorough test coverage for various scenarios, including immediate resolution, polling, abort signals, and timeouts, clearly enhancing functionality with real value.4da30057fix(plugin): harden metadata recovery and extraction -- The commit introduces meaningful functionality to extract session IDs from metadata, including legacy aliases, with clear test coverage and functional impact.c6a407c4refactor(tools): migrate producers to shared metadata bridge -- The commit refactors multiple files to migrate producers to a shared metadata bridge, replacingstoreToolMetadatawithpublishToolMetadataacross various task handlers, indicating a clear architectural improvement with broad impact.7bc170fbfix: installer writes hyphenated anthropic IDs, variant=max Anthropic OAuth compat (variant: max sends output_config which breaks Claude Pro/Max OAuth authentication code-yeongyu/oh-my-openagent#3429, [Bug]: installer generates invalid Anthropic model IDs with dotted version suffixes code-yeongyu/oh-my-openagent#3459) -- The commit fixes a concrete behavior issue by replacing dots with hyphens in Anthropic IDs for OAuth compatibility, as evidenced by the systematic replacement of '4.6' with '4-6' across all model configurations.Branch:
sync/upstream/v3.17.4-good(local only; not on origin)🟡 Review batch
Ambiguous. Human should review before merging.
79a475d6refactor(background-agent): simplify loop detector null guard -- Classification failed: No object generated: response did not match schema.141798efrefactor(background-agent): standardize loop detector null guards -- Classification failed: No object generated: response did not match schema.569addd3docs(provider): add comments to vercel transform logic -- Classification failed: No object generated: response did not match schema.Branch:
sync/upstream/v3.17.4-needs-review(on origin)🔴 Slop batch
Classified as AI slop or pointless churn. Do not merge as-is; rewrite intent if salvageable.
1e2e0019refactor(create-tools): keep result type internal -- The commit changes the visibility ofCreateToolsResultfromexportto internal without any clear functional or architectural benefit, fitting the 'minor_visibility_churn' category with no apparent payoff.9d89bbb0refactor(commands): keep builtin command options internal -- Changes the visibility ofLoadBuiltinCommandsOptionsfromexportto internal without clear functional or architectural benefit.0c5cd3a1chore(agents): update all AGENTS.md generation dates to 2026-04-11 -- The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn.e654cfb4@ahuangsnail has signed the CLA in fix: treat zero limit.output as unknown to enable fallback to bundled… code-yeongyu/oh-my-openagent#3316 -- CLA signature commit with no code/product value6713b30crefactor(hooks): drop no-op directory injector callbacks -- Removed no-op callbacks without adding new functionality or improving existing code structure in a meaningful way.6a0d515d@divlook has signed the CLA in fix: align GitHub Copilot model variants with catalog code-yeongyu/oh-my-openagent#3353 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.5b33cd22@lrq3000 has signed the CLA in docs(install): Update installation commands for humans in documentation to oh-my-openagent code-yeongyu/oh-my-openagent#3358 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.c6deb6d6@Zireael has signed the CLA in fix: detect Git Bash/WSL/MSYS2 shell on Windows (non-interactive-env hook) code-yeongyu/oh-my-openagent#3370 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.42df1c3c@FuDesign2008 has signed the CLA in fix(agent-key): restore getAgentDisplayName for HTTP-header-safe agent keys code-yeongyu/oh-my-openagent#3371 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.84f980c9@matchai has signed the CLA in feat(provider): add Vercel AI Gateway support code-yeongyu/oh-my-openagent#3376 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.678011c7docs(contributing): update tool/hook counts and version references -- The commit updates tool/hook counts and version references in the CONTRIBUTING.md file, which appears to be metadata churn with no addition of new substantive information or functional value.cfd152addocs(features): update agent count and verify category list -- Added two new agent descriptions with overly generic and vague capabilities, lacking concrete examples or clear user value beyond buzzwords.0cb0a6c0docs(contributing): update tool/hook counts and version references -- The commit updates tool/hook counts in CONTRIBUTING.md, which is metadata churn with no addition of new substantive information or functional value.3419bbc4@mauriciozaffari has signed the CLA in fix: recognize 'hit your limit' as retryable error pattern code-yeongyu/oh-my-openagent#3398 -- CLA signature commit with no code/product value1bb59c3erelease: v3.17.2 -- The commit is a release version bump with no code changes, only updating version numbers in multiple package.json files.571cf1f1@kywoo26 has signed the CLA in fix(background-agent): skip unavailable fallback models code-yeongyu/oh-my-openagent#3402 -- CLA signature commit with no code/product valuef98f7ec7@garnetlyx has signed the CLA in feat: Task ID semantics and lifecycle integrity (#3404, #3405) code-yeongyu/oh-my-openagent#3409 -- CLA signature commit with no code/product valued97c067d@lightrabbit has signed the CLA in fix(skill-mcp): pass workspace directory as cwd to stdio MCP processes code-yeongyu/oh-my-openagent#3415 -- CLA signature commit with no code/product valueeaf5ff21@fr1sk has signed the CLA in fix(agent-display): remove ZWSP sort prefixes that truncate agent names in terminals code-yeongyu/oh-my-openagent#3419 -- CLA signature commit with no code/product valuef8f7ac10@grandmaster451 has signed the CLA in fix(auto-update): use semantic version comparison instead of string e… code-yeongyu/oh-my-openagent#3420 -- CLA signature commit with no code/product value54a94d41@kithawk has signed the CLA in Fix primary agent model precedence code-yeongyu/oh-my-openagent#3428 -- CLA signature commit with no code/product value81a03fa9@orbisai0security has signed the CLA in fix: upgrade express-rate-limit to 8.2.2, 8.1.1, 8.0.2 (CVE-2026-30827) code-yeongyu/oh-my-openagent#3440 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.9aeb87c2chore: bump version to 3.17.3 -- The commit only updates the version number in package.json with no functional changes.80e73f57@CHLK has signed the CLA in fix(cli-run): prevent premature exit when background tasks are active code-yeongyu/oh-my-openagent#3455 -- The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value.fe091ef2chore: bump version to 3.17.4 -- The commit only updates the version number in package.json with no functional changes.c9350c67release: v3.17.4 -- The commit only updates version numbers in multiple package.json files with no functional changes, indicating administrative noise.Branch:
sync/upstream/v3.17.4-slop(on origin)Slop verifier second-pass notes
1e2e001CONFIRMED_SLOP (behavior delta: none): The commit changes the visibility ofCreateToolsResultfromexportto internal without any clear functional or architectural benefit. This fits the 'minor_visibility_churn' category with no apparent payoff, as the type is still defined identically but now less accessible. There's no concrete behavior delta, no new abstractions with multiple callers, and the commit message lacks justification for the change. A senior engineer would likely question the value of this change in a code review.9d89bbbCONFIRMED_SLOP (behavior delta: none): The commit changes the visibility ofLoadBuiltinCommandsOptionsfromexportto internal without clear functional or architectural benefit, aligning with minor_visibility_churn. No runtime behavior changes, and the interface's usage scope isn't broadened beyond its current single caller context. The change lacks a concrete justification or impact on the system's behavior, invariants, or user experience.0c5cd3aCONFIRMED_SLOP (behavior delta: none): The commit updates generation dates in multiple AGENTS.md files without adding new functionality or value beyond metadata churn, which aligns with the 'date_count_metadata_churn' slop signal. There is no concrete behavior delta, and the change does not introduce new functionality or improve existing code in a measurable way.e654cfbCONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.6713b30CONFIRMED_SLOP (behavior delta: none): The commit removes no-op callbacks without adding new functionality or improving existing code structure in a meaningful way. The changes are purely refactor_churn and removed unused code without clear benefit, aligning with documented slop patterns. No concrete behavior delta or user-visible changes are introduced.6a0d515CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the 'cla_admin' category, which is explicitly non-GOOD by the verification bias rules. No behavior delta exists as it doesn't alter runtime code or user-visible output.5b33cd2CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass reason correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not introduce any new functionality or improvements.c6deb6dCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This aligns with the 'cla_admin' slop signal and does not provide any concrete behavior delta or value to the codebase.42df1c3CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.84f980cCONFIRMED_SLOP (behavior delta: none): The commit adds only a CLA signature to cla.json, which is purely administrative with no impact on code or product functionality. This aligns with the 'cla_admin' slop signal and does not provide any measurable value to the repository's functionality or user experience.678011cCONFIRMED_SLOP (behavior delta: none): The commit updates counts and version references in a documentation file without adding substantive new information or functional value. The changes are metadata updates and do not alter any runtime behavior, user-visible output, or invariants. The commit message accurately reflects the changes but does not justify the addition of real value beyond churn.cfd152aCONFIRMED_SLOP (behavior delta: none): The commit adds two new agent descriptions with overly generic and vague capabilities, lacking concrete examples or clear user value beyond buzzwords. The commit message uses vague 'update' without a concrete behavior delta. The changes expand existing docs without adding new facts, aligning with documented slop patterns.0cb0a6cCONFIRMED_SLOP (behavior delta: none): The commit updates counts in a documentation file without adding new substantive information or functional value. This aligns with metadata churn, a documented slop pattern. No runtime behavior changes, and the update does not introduce new facts or capabilities beyond bookkeeping.3419bbcCONFIRMED_SLOP (behavior delta: none): The commit only updates a CLA signature JSON file with a new contributor's information, which is administrative in nature and does not add any code or product value. This aligns with the 'cla_admin' slop signal and does not meet the criteria for a GOOD commit as per the given rubric.1bb59c3CONFIRMED_SLOP (behavior delta: none): The commit is a release version bump with no code changes, only updating version numbers in multiple package.json files. This matches the 'release_version_bump' slop pattern, and according to the verification bias, such commits should not be demoted to GOOD. There is no concrete behavior delta, and the change is purely administrative.571cf1fCONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise without direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.f98f7ecCONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.d97c067CONFIRMED_SLOP (behavior delta: none): The commit only updates a CLA signature in cla.json without any code or product changes, aligning with documented slop patterns for administrative noise.eaf5ff2CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.f8f7ac1CONFIRMED_SLOP (behavior delta: none): The commit adds a CLA signature to cla.json, which is administrative noise with no direct code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias rules.54a94d4CONFIRMED_SLOP (behavior delta: none): The commit only updates a CLA signature in cla.json without any code or product changes, aligning with 'cla_admin' slop patterns. No behavior delta exists as it's administrative noise. A senior engineer would not defend this as value-adding in a code review focused on merge value.81a03faCONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. This matches the documented 'cla_admin' slop pattern, and there's no concrete behavior delta, abstraction, or user-visible change. A senior engineer would not defend this as value-adding in a code review focused on merge value.9aeb87cCONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the 'release_version_bump' slop pattern. No behavior delta exists as it's purely administrative. The first-pass verdict correctly identified it as SLOP.80e73f5CONFIRMED_SLOP (behavior delta: none): The commit only adds a CLA signature to cla.json, which is administrative noise with no code or product value. The first-pass verdict correctly identifies it as cla_admin, a category excluded from being demoted to GOOD by the verification bias. There is no concrete behavior delta, and the change does not impact runtime code or user-visible output.fe091efCONFIRMED_SLOP (behavior delta: none): The commit only updates the version number in package.json with no functional changes, aligning with the release_version_bump slop pattern. No behavior delta exists as it's purely administrative. A senior engineer would likely not defend this as valuable in a code review focused on functional merge value.c9350c6CONFIRMED_SLOP (behavior delta: none): The commit only updates version numbers in multiple package.json files with no functional changes, indicating administrative noise. This aligns with the 'release_version_bump' category, which is explicitly non-GOOD by the rubric. No behavior delta exists as the changes are purely version updates.Fork-sync impact assessment
Breaking changes
(none detected)
Dependency changes
Architecture drift
(none)
Hidden concerns
Action items before merging
Generated by
upstream-analyzerworkflow. This issue is advisory: no merges or publishes happen automatically. Phase 1: draft PRs only. The prompt lives in.github/prompts/and is editable without touching workflow code.Classify chain:
openrouter:qwen/qwen3-coder:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1-miniSlop-verify chain:
openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1Synthesis chain:
openrouter:nvidia/nemotron-3-super-120b-a12b:free → nvidia:nvidia/llama-3.3-nemotron-super-49b-v1 → github:openai/gpt-4.1