I met compile error with fmt

[jamalyang]

It seems that some formatter of classes are not implemented, and I met compile error with fmt library when it need to format some class, e.g. when debugPrint(..., Rect&) in dbGuide::Create. Is there anythign wrong with my libfmt version?

[jamalyang]

/usr/include/fmt/core.h: In instantiation of ‘constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_value(T&&) [with Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; T = const cts::Box<double>&]’:
/usr/include/fmt/core.h:1777:29:   required from ‘constexpr fmt::v9::detail::value<Context> fmt::v9::detail::make_arg(T&&) [with bool IS_PACKED = true; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; type <anonymous> = fmt::v9::detail::type::custom_type; T = const cts::Box<double>&; typename std::enable_if<IS_PACKED, int>::type <anonymous> = 0]’
/usr/include/fmt/core.h:1901:77:   required from ‘constexpr fmt::v9::format_arg_store<Context, Args>::format_arg_store(T&& ...) [with T = {const char* const&, const char* const&, int&, const cts::Box<double>&}; Context = fmt::v9::basic_format_context<fmt::v9::appender, char>; Args = {const char*, const char*, int, cts::Box<double>}]’
/usr/include/fmt/core.h:1918:31:   required from ‘constexpr fmt::v9::format_arg_store<Context, typename std::remove_cv<typename std::remove_reference<Args>::type>::type ...> fmt::v9::make_format_args(Args&& ...) [with Context = basic_format_context<appender, char>; Args = {const char* const&, const char* const&, int&, const cts::Box<double>&}]’
/usr/include/spdlog/logger.h:370:68:   required from ‘void spdlog::logger::log_(spdlog::source_loc, spdlog::level::level_enum, spdlog::string_view_t, Args&& ...) [with Args = {const char* const&, const char* const&, int&, const cts::Box<double>&}; spdlog::string_view_t = fmt::v9::basic_string_view<char>]’
/usr/include/spdlog/logger.h:90:13:   required from ‘void spdlog::logger::log(spdlog::source_loc, spdlog::level::level_enum, fmt::v9::format_string<T ...>, Args&& ...) [with Args = {const char* const&, const char* const&, int&, const cts::Box<double>&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, const char* const&, const char* const&, int&, const cts::Box<double>&>]’
/usr/include/spdlog/logger.h:96:12:   required from ‘void spdlog::logger::log(spdlog::level::level_enum, fmt::v9::format_string<T ...>, Args&& ...) [with Args = {const char* const&, const char* const&, int&, const cts::Box<double>&}; fmt::v9::format_string<T ...> = fmt::v9::basic_format_string<char, const char* const&, const char* const&, int&, const cts::Box<double>&>]’
/home/*/*/*/*/OpenROAD/src/utl/include/utl/Logger.h:270:19:   required from ‘void utl::Logger::log(utl::ToolId, spdlog::level::level_enum, int, const std::string&, const Args& ...) [with Args = {cts::Box<double>}; std::string = std::__cxx11::basic_string<char>]’
/home/*/*/*/*/OpenROAD/src/utl/include/utl/Logger.h:136:8:   required from ‘void utl::Logger::info(utl::ToolId, int, const std::string&, const Args& ...) [with Args = {cts::Box<double>}; std::string = std::__cxx11::basic_string<char>]’
/home/*/*/*/*/OpenROAD/src/cts/src/HTreeBuilder.cpp:321:16:   required from here
/usr/include/fmt/core.h:1757:7: error: static assertion failed: Cannot format an argument. To make type T formattable provide a formatter<T> specialization: https://fmt.dev/latest/api.html#udt
/usr/include/fmt/core.h:1757:7: note: ‘formattable’ evaluates to false

[maliberty]

What os? What compiler? What version of fmt? Did you run the dependency installer? This would have been better filed as an issue.

[jamalyang]

I just read the dependency installer, and install lacked denpendencies manually. There may be version issues.

Here is the environment:

$ cat /etc/os-release 
PRETTY_NAME="Debian GNU/Linux 12 (bookworm)"
NAME="Debian GNU/Linux"
VERSION_ID="12"
VERSION="12 (bookworm)"
VERSION_CODENAME=bookworm
ID=debian
HOME_URL="https://www.debian.org/"
SUPPORT_URL="https://www.debian.org/support"
BUG_REPORT_URL="https://bugs.debian.org/"

 g++ -v
Using built-in specs.
COLLECT_GCC=g++
COLLECT_LTO_WRAPPER=/usr/lib/gcc/x86_64-linux-gnu/12/lto-wrapper
OFFLOAD_TARGET_NAMES=nvptx-none:amdgcn-amdhsa
OFFLOAD_TARGET_DEFAULT=1
Target: x86_64-linux-gnu
Configured with: ../src/configure -v --with-pkgversion='Debian 12.2.0-14+deb12u1' --with-bugurl=file:///usr/share/doc/gcc-12/README.Bugs --enable-languages=c,ada,c++,go,d,fortran,objc,obj-c++,m2 --prefix=/usr --with-gcc-major-version-only --program-suffix=-12 --program-prefix=x86_64-linux-gnu- --enable-shared --enable-linker-build-id --libexecdir=/usr/lib --without-included-gettext --enable-threads=posix --libdir=/usr/lib --enable-nls --enable-clocale=gnu --enable-libstdcxx-debug --enable-libstdcxx-time=yes --with-default-libstdcxx-abi=new --enable-gnu-unique-object --disable-vtable-verify --enable-plugin --enable-default-pie --with-system-zlib --enable-libphobos-checking=release --with-target-system-zlib=auto --enable-objc-gc=auto --enable-multiarch --disable-werror --enable-cet --with-arch-32=i686 --with-abi=m64 --with-multilib-list=m32,m64,mx32 --enable-multilib --with-tune=generic --enable-offload-targets=nvptx-none=/build/reproducible-path/gcc-12-12.2.0/debian/tmp-nvptx/usr,amdgcn-amdhsa=/build/reproducible-path/gcc-12-12.2.0/debian/tmp-gcn/usr --enable-offload-defaulted --without-cuda-driver --enable-checking=release --build=x86_64-linux-gnu --host=x86_64-linux-gnu --target=x86_64-linux-gnu
Thread model: posix
Supported LTO compression algorithms: zlib zstd
gcc version 12.2.0 (Debian 12.2.0-14+deb12u1) 

$ grep -n "FMT_VERSION" /usr/include/fmt/core.h
20:#define FMT_VERSION 90100

$ apt show libfmt-dev
Package: libfmt-dev
Version: 9.1.0+ds1-2
Priority: optional
Section: libdevel
Source: fmtlib
Maintainer: Shengjing Zhu <zhsj@debian.org>
Installed-Size: 648 kB
Depends: libfmt9 (= 9.1.0+ds1-2)
Suggests: libfmt-doc
Conflicts: libcppformat1-dev, libcppformat2-dev, libfmt3-dev
Breaks: libspdlog-dev (<< 1:1.9.2+ds-0.1)
Homepage: https://fmt.dev/
Tag: devel::library, role::devel-lib
Download-Size: 171 kB
APT-Manual-Installed: yes
APT-Sources: https://mirrors.tuna.tsinghua.edu.cn/debian bookworm/main amd64 Packages
Description: fast type-safe C++ formatting library -- development files
 This library provides fast, type-safe, small, C++11-aware replacement of
 (s)printf and related machinery. In some cases it's noticeably faster
 than boost::format, boost::lexical_cast and even sprintf itself.
 .
 This package contains the development files, include the static library.

If it is need, I will file a issues later.

PS: I noticed that you have implemented the operator<<() for those classed, but formatter is not implemented. All the compiler errors for fmt are reprorted through spdlog. Did you compile the objects with this flag seting to true when setup Cmake?

spdlog: 1.10.0
CMake Warning at src/CMakeLists.txt:238 (message):
spdlog: SPDLOG_FMT_EXTERNAL=ON

[maliberty]

The dependency installer uses 1.15.0; we don't test on 1.10.0 and I can't say it will work. Is there a reason not to use 1.15 which does work in our nightly CI?

[jamalyang]

No spicial reason, I just prefer to manange developement environment by myself.

I tried to compile a spdlog v1.15.0 as the dependency installer did (which will be built without external fmt lib by default), and it works.
Suspecting the failed reason is that libfmt provided by apt was built with external fmt lib ( as the src/CMakeLists.txt:238 warned ), which will use libfmt as the formatter instead of the basic stream, and operator<<() you have implemented in the code is not worked.

Thanks a lot.