Revert "refactor: replace native window tabs with in-app tab bar (#763)"

This reverts commit bad2466.

Author: datlechin

CHANGELOG.md

@@ -9,18 +9,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [0.32.0] - 2026-04-16
 
-### Added
-
-- In-app tab bar with instant switching, drag reorder, pinned tabs, and dirty indicators
-- Reopen closed tab (Cmd+Shift+T), MRU tab selection on close
-- Deeplinks and Handoff route to in-app tabs instead of creating duplicate windows
-
-### Changed
-
-- Replace native macOS window tabs with in-app tab bar (600ms+ → instant)
-- Tab content preserved across switches (no view destruction/recreation)
-- Connection state persisted incrementally (survives force quit)
-
 ### Fixed
 
 - Raw SQL injection via external URL scheme deeplinks — now requires user confirmation

TablePro/AppDelegate+ConnectionHandler.swift

@@ -92,7 +92,9 @@ extension AppDelegate {
             do {
                 try await DatabaseManager.shared.connectToSession(connection)
                 self.openNewConnectionWindow(for: connection)
-                self.closeAllWelcomeWindows()
+                for window in NSApp.windows where self.isWelcomeWindow(window) {
+                    window.close()
+                }
                 self.handlePostConnectionActions(parsed, connectionId: connection.id)
             } catch {
                 connectionLogger.error("Database URL connect failed: \(error.localizedDescription)")
@@ -141,7 +143,9 @@ extension AppDelegate {
             do {
                 try await DatabaseManager.shared.connectToSession(connection)
                 self.openNewConnectionWindow(for: connection)
-                self.closeAllWelcomeWindows()
+                for window in NSApp.windows where self.isWelcomeWindow(window) {
+                    window.close()
+                }
             } catch {
                 connectionLogger.error("SQLite file open failed for '\(filePath, privacy: .public)': \(error.localizedDescription)")
                 await self.handleConnectionFailure(error)
@@ -189,7 +193,9 @@ extension AppDelegate {
             do {
                 try await DatabaseManager.shared.connectToSession(connection)
                 self.openNewConnectionWindow(for: connection)
-                self.closeAllWelcomeWindows()
+                for window in NSApp.windows where self.isWelcomeWindow(window) {
+                    window.close()
+                }
             } catch {
                 connectionLogger.error("DuckDB file open failed for '\(filePath, privacy: .public)': \(error.localizedDescription)")
                 await self.handleConnectionFailure(error)
@@ -237,7 +243,9 @@ extension AppDelegate {
             do {
                 try await DatabaseManager.shared.connectToSession(connection)
                 self.openNewConnectionWindow(for: connection)
-                self.closeAllWelcomeWindows()
+                for window in NSApp.windows where self.isWelcomeWindow(window) {
+                    window.close()
+                }
             } catch {
                 connectionLogger.error("File open failed for '\(filePath, privacy: .public)' (\(dbType.rawValue)): \(error.localizedDescription)")
                 await self.handleConnectionFailure(error)
@@ -342,9 +350,7 @@ extension AppDelegate {
                     tableName: tableName,
                     isView: parsed.isView
                 )
-                if !routeToExistingWindow(connectionId: connectionId, payload: payload) {
-                    WindowOpener.shared.openNativeTab(payload)
-                }
+                WindowOpener.shared.openNativeTab(payload)
 
                 if parsed.filterColumn != nil || parsed.filterCondition != nil {
                     await waitForNotification(.refreshData, timeout: .seconds(3))
@@ -469,12 +475,6 @@ extension AppDelegate {
         return "\(parsed.type.rawValue):\(parsed.username)@\(parsed.host):\(parsed.port ?? 0)/\(parsed.database)\(rdb)"
     }
 
-    func closeAllWelcomeWindows() {
-        for window in NSApp.windows where isWelcomeWindow(window) {
-            window.close()
-        }
-    }
-
     func bringConnectionWindowToFront(_ connectionId: UUID) {
         let windows = WindowLifecycleMonitor.shared.windows(for: connectionId)
         if let window = windows.first {

TablePro/AppDelegate+FileOpen.swift

@@ -32,39 +32,31 @@ extension AppDelegate {
 
         let tableName = activity.userInfo?["tableName"] as? String
 
-        // Already connected — route to existing window's in-app tab bar
         if DatabaseManager.shared.activeSessions[connectionId]?.driver != nil {
             if let tableName {
                 let payload = EditorTabPayload(connectionId: connectionId, tabType: .table, tableName: tableName)
-                if !routeToExistingWindow(connectionId: connectionId, payload: payload) {
-                    WindowOpener.shared.openNativeTab(payload)
-                }
+                WindowOpener.shared.openNativeTab(payload)
             } else {
-                bringConnectionWindowToFront(connectionId)
+                for window in NSApp.windows where isMainWindow(window) {
+                    window.makeKeyAndOrderFront(nil)
+                    return
+                }
             }
             return
         }
 
-        // Window already pending (e.g., auto-reconnect in progress) — just bring to front
-        let hasPending = WindowOpener.shared.pendingPayloads.contains { $0.connectionId == connectionId }
-        if hasPending {
-            bringConnectionWindowToFront(connectionId)
-            return
-        }
-
-        // Not connected — create window, connect, then route content as in-app tab
-        let initialPayload = EditorTabPayload(connectionId: connectionId, intent: .restoreOrDefault)
+        let initialPayload = EditorTabPayload(connectionId: connectionId)
         WindowOpener.shared.openNativeTab(initialPayload)
 
         Task { @MainActor in
             do {
                 try await DatabaseManager.shared.connectToSession(connection)
-                self.closeAllWelcomeWindows()
+                for window in NSApp.windows where self.isWelcomeWindow(window) {
+                    window.close()
+                }
                 if let tableName {
                     let payload = EditorTabPayload(connectionId: connectionId, tabType: .table, tableName: tableName)
-                    if !routeToExistingWindow(connectionId: connectionId, payload: payload) {
-                        WindowOpener.shared.openNativeTab(payload)
-                    }
+                    WindowOpener.shared.openNativeTab(payload)
                 }
             } catch {
                 fileOpenLogger.error("Handoff connect failed: \(error.localizedDescription)")
@@ -94,11 +86,6 @@ extension AppDelegate {
     // MARK: - Main Dispatch
 
     func handleOpenURLs(_ urls: [URL]) {
-        // application(_:open:) fires in the same run loop pass as applicationDidFinishLaunching
-        // on cold launch from URL. The deferred auto-reconnect Task yields to the next run loop,
-        // so this flag is guaranteed to be set before the Task checks it.
-        suppressAutoReconnect = true
-
         let deeplinks = urls.filter { $0.scheme == "tablepro" }
         if !deeplinks.isEmpty {
             Task { @MainActor in
@@ -156,7 +143,9 @@ extension AppDelegate {
                 for window in NSApp.windows where isMainWindow(window) {
                     window.makeKeyAndOrderFront(nil)
                 }
-                closeAllWelcomeWindows()
+                for window in NSApp.windows where isWelcomeWindow(window) {
+                    window.close()
+                }
                 NotificationCenter.default.post(name: .openSQLFiles, object: sqlFiles)
                 endFileOpenSuppression()
             } else {
@@ -166,36 +155,6 @@ extension AppDelegate {
         }
     }
 
-    // MARK: - In-App Tab Routing
-
-    /// Route content to an existing connection window's in-app tab bar when possible.
-    /// Returns true if the content was routed to an existing window.
-    /// Falls back gracefully (returns false) when no coordinator exists for the connection.
-    @discardableResult
-    func routeToExistingWindow(
-        connectionId: UUID,
-        payload: EditorTabPayload
-    ) -> Bool {
-        guard let coordinator = MainContentCoordinator.firstCoordinator(for: connectionId) else {
-            return false
-        }
-        switch payload.tabType {
-        case .table:
-            if let tableName = payload.tableName {
-                coordinator.openTableTab(tableName, showStructure: payload.showStructure, isView: payload.isView)
-            }
-        case .query:
-            coordinator.tabManager.addTab(
-                initialQuery: payload.initialQuery,
-                databaseName: payload.databaseName ?? coordinator.connection.database
-            )
-        default:
-            coordinator.addNewQueryTab()
-        }
-        coordinator.contentWindow?.makeKeyAndOrderFront(nil)
-        return true
-    }
-
     // MARK: - Welcome Window Suppression
 
     func suppressWelcomeWindow() {
@@ -257,7 +216,7 @@ extension AppDelegate {
         makePayload: (@Sendable (UUID) -> EditorTabPayload)? = nil
     ) {
         guard let connection = DeeplinkHandler.resolveConnection(named: connectionName) else {
-            fileOpenLogger.error("No connection named '\(connectionName, privacy: .public)'")
+            fileOpenLogger.error("Deep link: no connection named '\(connectionName, privacy: .public)'")
             AlertHelper.showErrorSheet(
                 title: String(localized: "Connection Not Found"),
                 message: String(format: String(localized: "No saved connection named \"%@\"."), connectionName),
@@ -266,47 +225,27 @@ extension AppDelegate {
             return
         }
 
-        let hasDriver = DatabaseManager.shared.activeSessions[connection.id]?.driver != nil
-        let hasCoordinator = MainContentCoordinator.firstCoordinator(for: connection.id) != nil
-
-        // Already connected — route to existing window's in-app tab bar
-        if hasDriver {
+        if DatabaseManager.shared.activeSessions[connection.id]?.driver != nil {
             if let payload = makePayload?(connection.id) {
-                if !routeToExistingWindow(connectionId: connection.id, payload: payload) {
-                    WindowOpener.shared.openNativeTab(payload)
-                }
+                WindowOpener.shared.openNativeTab(payload)
             } else {
-                bringConnectionWindowToFront(connection.id)
+                for window in NSApp.windows where isMainWindow(window) {
+                    window.makeKeyAndOrderFront(nil)
+                    return
+                }
             }
             return
         }
 
-        // Prevent duplicate connections from rapid deeplink invocations
-        let hasPendingWindow = WindowOpener.shared.pendingPayloads.contains { $0.connectionId == connection.id }
-        let isAlreadyConnecting = connectingURLConnectionIds.contains(connection.id)
-        guard !isAlreadyConnecting, !hasPendingWindow else {
-            bringConnectionWindowToFront(connection.id)
-            return
-        }
-
-        // Has coordinator but no driver — window exists, connection may be in progress
-        if hasCoordinator {
-            bringConnectionWindowToFront(connection.id)
-            return
-        }
-
         let hadExistingMain = NSApp.windows.contains { isMainWindow($0) && $0.isVisible }
         if hadExistingMain && !AppSettingsManager.shared.tabs.groupAllConnectionTabs {
             NSWindow.allowsAutomaticWindowTabbing = false
         }
 
-        connectingURLConnectionIds.insert(connection.id)
-
-        let deeplinkPayload = EditorTabPayload(connectionId: connection.id, intent: .restoreOrDefault)
+        let deeplinkPayload = EditorTabPayload(connectionId: connection.id)
         WindowOpener.shared.openNativeTab(deeplinkPayload)
 
         Task { @MainActor in
-            defer { self.connectingURLConnectionIds.remove(connection.id) }
             do {
                 // Confirm pre-connect script if present (deep links are external, so always confirm)
                 if let script = connection.preConnectScript,
@@ -323,14 +262,14 @@ extension AppDelegate {
                 }
 
                 try await DatabaseManager.shared.connectToSession(connection)
-                self.closeAllWelcomeWindows()
+                for window in NSApp.windows where self.isWelcomeWindow(window) {
+                    window.close()
+                }
                 if let payload = makePayload?(connection.id) {
-                    if !self.routeToExistingWindow(connectionId: connection.id, payload: payload) {
-                        WindowOpener.shared.openNativeTab(payload)
-                    }
+                    WindowOpener.shared.openNativeTab(payload)
                 }
             } catch {
-                fileOpenLogger.error("Deeplink connect failed for \"\(connectionName, privacy: .public)\": \(error.localizedDescription, privacy: .public)")
+                fileOpenLogger.error("Deep link connect failed: \(error.localizedDescription)")
                 await self.handleConnectionFailure(error)
             }
         }