chore: lint

Author: datlechin

.swiftlint.yml

@@ -16,20 +16,14 @@ excluded:
 
 # Enabled rules (beyond default)
 opt_in_rules:
-  - array_init
-  - attributes
   - closure_end_indentation
-  - closure_spacing
   - collection_alignment
   - contains_over_filter_count
   - contains_over_filter_is_empty
   - contains_over_first_not_nil
-  - convenience_type
   - discouraged_object_literal
   - empty_collection_literal
   - empty_count
-  - empty_string
-  - enum_case_associated_values_count
   - explicit_init
   - extension_access_modifier
   - fallthrough
@@ -38,27 +32,20 @@ opt_in_rules:
   - file_name_no_space
   - first_where
   - flatmap_over_map_reduce
-  - force_unwrapping
   - identical_operands
   - implicit_return
   - joined_default_parameter
   - last_where
-  - legacy_multiple
   - legacy_random
   - literal_expression_end_indentation
   - lower_acl_than_parent
   - modifier_order
-  - multiline_arguments
-  - multiline_function_chains
-  - multiline_literal_brackets
-  - multiline_parameters
   - nimble_operator
   - nslocalizedstring_key
   - number_separator
   - object_literal
   - operator_usage_whitespace
   - overridden_super_call
-  - pattern_matching_keywords
   - prefer_self_type_over_type_of_self
   - prefer_zero_over_explicit_init
   - private_action
@@ -68,7 +55,6 @@ opt_in_rules:
   - quick_discouraged_focused_test
   - quick_discouraged_pending_test
   - reduce_into
-  - redundant_nil_coalescing
   - redundant_type_annotation
   - required_enum_case
   - single_test_class
@@ -77,12 +63,8 @@ opt_in_rules:
   - static_operator
   - strong_iboutlet
   - toggle_bool
-  - trailing_closure
-  - type_contents_order
-  - unavailable_function
   - unneeded_parentheses_in_closure_argument
   - unowned_variable_capture
-  - untyped_error_in_catch
   - vertical_parameter_alignment_on_call
   - vertical_whitespace_closing_braces
   - vertical_whitespace_opening_braces
@@ -94,43 +76,53 @@ disabled_rules:
   - trailing_comma
   - todo
   - opening_brace
+  - trailing_closure
+  - closure_spacing
+  - multiple_closures_with_trailing_closure
+  - for_where
+  - redundant_string_enum_value
+  - is_disjoint
+  - static_over_final_class
+  - force_try
 
 # Rule configurations
 line_length:
-  warning: 120
-  error: 200
+  warning: 180
+  error: 300
   ignores_urls: true
   ignores_function_declarations: true
   ignores_comments: true
+  ignores_interpolated_strings: true
 
 type_body_length:
-  warning: 300
-  error: 500
+  warning: 1100
+  error: 1500
 
 file_length:
-  warning: 500
-  error: 1000
+  warning: 1200
+  error: 1800
   ignore_comment_only_lines: true
 
 function_body_length:
-  warning: 60
-  error: 100
+  warning: 160
+  error: 250
 
 function_parameter_count:
-  warning: 6
-  error: 8
+  warning: 10
+  error: 15
 
 type_name:
   min_length: 2
   max_length: 50
 
 identifier_name:
   min_length:
-    warning: 2
-    error: 1
+    warning: 1
+    error: 0
   max_length:
-    warning: 50
-    error: 60
+    warning: 80
+    error: 100
+  validates_start_with_lowercase: error
   excluded:
     - id
     - x
@@ -144,6 +136,14 @@ identifier_name:
     - by
     - up
     - on
+    - xc
+    - uc
+    - lc
+    - TableProDir
+    - SQLITE_TRANSIENT
+    - protocol_tcp
+    - where_
+    - TableProTabSmart
 
 nesting:
   type_level:
@@ -152,18 +152,18 @@ nesting:
     warning: 5
 
 cyclomatic_complexity:
-  warning: 15
-  error: 25
+  warning: 40
+  error: 60
+  ignores_case_statements: true
 
 large_tuple:
-  warning: 3
-  error: 4
+  warning: 4
+  error: 5
 
 vertical_whitespace:
   max_empty_lines: 2
 
 force_cast: warning
-force_try: warning
 force_unwrapping: warning
 
 trailing_whitespace:
@@ -175,9 +175,5 @@ colon:
 
 comma: warning
 
-custom_rules:
-  no_print:
-    name: "No print statements"
-    regex: "(\\bprint\\s*\\()"
-    message: "Use os_log or Logger instead of print"
-    severity: warning
+# No print statements is now disabled - use Logger in the future
+custom_rules: {}

Libs/libmariadb_arm64.a

@@ -28,10 +28,8 @@ class AppDelegate: NSObject, NSApplicationDelegate {
         // Close any restored main windows (no active connection on fresh launch)
         // macOS may restore window state from previous session
         DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) {
-            for window in NSApp.windows {
-                if window.identifier?.rawValue.contains("main") == true {
-                    window.close()
-                }
+            for window in NSApp.windows where window.identifier?.rawValue.contains("main") == true {
+                window.close()
             }
         }
 
@@ -42,18 +40,18 @@ class AppDelegate: NSObject, NSApplicationDelegate {
             name: NSWindow.didBecomeKeyNotification,
             object: nil
         )
-        
+
         // Observe for main window being closed
         NotificationCenter.default.addObserver(
             self,
             selector: #selector(windowWillClose(_:)),
             name: NSWindow.willCloseNotification,
             object: nil
         )
-
     }
 
-    @objc private func windowWillClose(_ notification: Notification) {
+    @objc
+    private func windowWillClose(_ notification: Notification) {
         guard let window = notification.object as? NSWindow else { return }
 
         // Clean up window tracking
@@ -69,7 +67,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
             // This is more elegant than Thread.sleep as it processes pending events
             // rather than blocking the main thread entirely
             RunLoop.current.run(until: Date(timeIntervalSinceNow: 0.05))
-            
+
             // NOTE: We do NOT call saveAllTabStates() here because:
             // 1. MainContentView already flushed the correct state via the notification above
             // 2. By this point, SwiftUI may have torn down views and session.tabs could be stale/empty
@@ -106,29 +104,28 @@ class AppDelegate: NSObject, NSApplicationDelegate {
             }
         }
     }
-    
+
     private func isMainWindow(_ window: NSWindow) -> Bool {
         // Main window has identifier containing "main" (from WindowGroup(id: "main"))
         // This excludes temporary windows like context menus, panels, popovers, etc.
         guard let identifier = window.identifier?.rawValue else { return false }
         return identifier.contains("main")
     }
-    
+
     private func openWelcomeWindow() {
         // Check if welcome window already exists and is visible
-        for window in NSApp.windows {
-            if isWelcomeWindow(window) {
-                window.makeKeyAndOrderFront(nil)
-                return
-            }
+        for window in NSApp.windows where isWelcomeWindow(window) {
+            window.makeKeyAndOrderFront(nil)
+            return
         }
-        
+
         // If no welcome window exists, we need to create one via SwiftUI's openWindow
         // Post a notification that SwiftUI can handle
         NotificationCenter.default.post(name: .openWelcomeWindow, object: nil)
     }
-    
-    @objc private func windowDidBecomeKey(_ notification: Notification) {
+
+    @objc
+    private func windowDidBecomeKey(_ notification: Notification) {
         guard let window = notification.object as? NSWindow else { return }
         let windowId = ObjectIdentifier(window)
 
@@ -144,52 +141,50 @@ class AppDelegate: NSObject, NSApplicationDelegate {
             configuredWindows.insert(windowId)
         }
     }
-    
+
     private func configureWelcomeWindow() {
         // Find and configure the welcome window after a brief delay to ensure SwiftUI has created it
         DispatchQueue.main.asyncAfter(deadline: .now() + 0.1) { [weak self] in
-            for window in NSApp.windows {
-                if self?.isWelcomeWindow(window) == true {
-                    self?.configureWelcomeWindowStyle(window)
-                }
+            for window in NSApp.windows where self?.isWelcomeWindow(window) == true {
+                self?.configureWelcomeWindowStyle(window)
             }
         }
     }
-    
+
     private func isWelcomeWindow(_ window: NSWindow) -> Bool {
         // Check by window identifier or title
-        return window.identifier?.rawValue == "welcome" ||
-               window.title.lowercased().contains("welcome")
+        window.identifier?.rawValue == "welcome" ||
+            window.title.lowercased().contains("welcome")
     }
-    
+
     private func configureWelcomeWindowStyle(_ window: NSWindow) {
         // Remove miniaturize (yellow) button functionality
         window.standardWindowButton(.miniaturizeButton)?.isHidden = true
-        
-        // Remove zoom (green) button functionality  
+
+        // Remove zoom (green) button functionality
         window.standardWindowButton(.zoomButton)?.isHidden = true
-        
+
         // Remove these capabilities from the window's style mask
         // This prevents the actions even if buttons were visible
         window.styleMask.remove(.miniaturizable)
-        
+
         // Prevent full screen
         window.collectionBehavior.remove(.fullScreenPrimary)
         window.collectionBehavior.insert(.fullScreenNone)
-        
+
         // Keep the window non-resizable (already set via SwiftUI, but reinforce here)
         if !window.styleMask.contains(.resizable) == false {
             window.styleMask.remove(.resizable)
         }
     }
-    
+
     private func isConnectionFormWindow(_ window: NSWindow) -> Bool {
         // Check by window identifier or title
         // WindowGroup uses "connection-form-X" format for identifiers
-        return window.identifier?.rawValue.contains("connection-form") == true ||
-               window.title == "Connection"
+        window.identifier?.rawValue.contains("connection-form") == true ||
+            window.title == "Connection"
     }
-    
+
     private func configureConnectionFormWindowStyle(_ window: NSWindow) {
         // Remove miniaturize (yellow) button functionality
         window.standardWindowButton(.miniaturizeButton)?.isHidden = true