Skip to content
This repository was archived by the owner on Apr 11, 2024. It is now read-only.

Commit 35ec8f8

Browse files
paulomargpaulomarg
authored
Merge pull request #1331 from Shopify/fix_recurring_charge_currencies
Fix recurring app charge currency type
2 parents 4b31178 + 513f9e6 commit 35ec8f8

8 files changed

Lines changed: 19 additions & 42 deletions

File tree

‎.changeset/young-hotels-agree.md‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@shopify/shopify-api": patch
3+
---
4+
5+
Fixed an issue with the `RecurringApplicationCharge` REST resource currency type

‎packages/shopify-api/rest/admin/2022-10/recurring_application_charge.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
77
import {Session} from '../../../lib/session/session';
88
import {ApiVersion} from '../../../lib/types';
99

10-
import {Currency} from './currency';
11-
1210
interface FindArgs {
1311
session: Session;
1412
id: number | string;
@@ -32,9 +30,7 @@ interface CustomizeArgs {
3230
export class RecurringApplicationCharge extends Base {
3331
public static apiVersion = ApiVersion.October22;
3432

35-
protected static hasOne: {[key: string]: typeof Base} = {
36-
"currency": Currency
37-
};
33+
protected static hasOne: {[key: string]: typeof Base} = {};
3834
protected static hasMany: {[key: string]: typeof Base} = {};
3935
protected static paths: ResourcePath[] = [
4036
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
@@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
124120
public capped_amount: string | number | null;
125121
public confirmation_url: string | null;
126122
public created_at: string | null;
127-
public currency: Currency | null | {[key: string]: any};
123+
public currency: string | null;
128124
public id: number | null;
129125
public name: string | null;
130126
public price: string | number | null;

‎packages/shopify-api/rest/admin/2023-01/recurring_application_charge.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
77
import {Session} from '../../../lib/session/session';
88
import {ApiVersion} from '../../../lib/types';
99

10-
import {Currency} from './currency';
11-
1210
interface FindArgs {
1311
session: Session;
1412
id: number | string;
@@ -32,9 +30,7 @@ interface CustomizeArgs {
3230
export class RecurringApplicationCharge extends Base {
3331
public static apiVersion = ApiVersion.January23;
3432

35-
protected static hasOne: {[key: string]: typeof Base} = {
36-
"currency": Currency
37-
};
33+
protected static hasOne: {[key: string]: typeof Base} = {};
3834
protected static hasMany: {[key: string]: typeof Base} = {};
3935
protected static paths: ResourcePath[] = [
4036
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
@@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
124120
public capped_amount: string | number | null;
125121
public confirmation_url: string | null;
126122
public created_at: string | null;
127-
public currency: Currency | null | {[key: string]: any};
123+
public currency: string | null;
128124
public id: number | null;
129125
public name: string | null;
130126
public price: string | number | null;

‎packages/shopify-api/rest/admin/2023-04/recurring_application_charge.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
77
import {Session} from '../../../lib/session/session';
88
import {ApiVersion} from '../../../lib/types';
99

10-
import {Currency} from './currency';
11-
1210
interface FindArgs {
1311
session: Session;
1412
id: number | string;
@@ -32,9 +30,7 @@ interface CustomizeArgs {
3230
export class RecurringApplicationCharge extends Base {
3331
public static apiVersion = ApiVersion.April23;
3432

35-
protected static hasOne: {[key: string]: typeof Base} = {
36-
"currency": Currency
37-
};
33+
protected static hasOne: {[key: string]: typeof Base} = {};
3834
protected static hasMany: {[key: string]: typeof Base} = {};
3935
protected static paths: ResourcePath[] = [
4036
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
@@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
124120
public capped_amount: string | number | null;
125121
public confirmation_url: string | null;
126122
public created_at: string | null;
127-
public currency: Currency | null | {[key: string]: any};
123+
public currency: string | null;
128124
public id: number | null;
129125
public name: string | null;
130126
public price: string | number | null;

‎packages/shopify-api/rest/admin/2023-07/recurring_application_charge.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
77
import {Session} from '../../../lib/session/session';
88
import {ApiVersion} from '../../../lib/types';
99

10-
import {Currency} from './currency';
11-
1210
interface FindArgs {
1311
session: Session;
1412
id: number | string;
@@ -32,9 +30,7 @@ interface CustomizeArgs {
3230
export class RecurringApplicationCharge extends Base {
3331
public static apiVersion = ApiVersion.July23;
3432

35-
protected static hasOne: {[key: string]: typeof Base} = {
36-
"currency": Currency
37-
};
33+
protected static hasOne: {[key: string]: typeof Base} = {};
3834
protected static hasMany: {[key: string]: typeof Base} = {};
3935
protected static paths: ResourcePath[] = [
4036
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
@@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
124120
public capped_amount: string | number | null;
125121
public confirmation_url: string | null;
126122
public created_at: string | null;
127-
public currency: Currency | null | {[key: string]: any};
123+
public currency: string | null;
128124
public id: number | null;
129125
public name: string | null;
130126
public price: string | number | null;

‎packages/shopify-api/rest/admin/2023-10/recurring_application_charge.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
77
import {Session} from '../../../lib/session/session';
88
import {ApiVersion} from '../../../lib/types';
99

10-
import {Currency} from './currency';
11-
1210
interface FindArgs {
1311
session: Session;
1412
id: number | string;
@@ -32,9 +30,7 @@ interface CustomizeArgs {
3230
export class RecurringApplicationCharge extends Base {
3331
public static apiVersion = ApiVersion.October23;
3432

35-
protected static hasOne: {[key: string]: typeof Base} = {
36-
"currency": Currency
37-
};
33+
protected static hasOne: {[key: string]: typeof Base} = {};
3834
protected static hasMany: {[key: string]: typeof Base} = {};
3935
protected static paths: ResourcePath[] = [
4036
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
@@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
124120
public capped_amount: string | number | null;
125121
public confirmation_url: string | null;
126122
public created_at: string | null;
127-
public currency: Currency | null | {[key: string]: any};
123+
public currency: string | null;
128124
public id: number | null;
129125
public name: string | null;
130126
public price: string | number | null;

‎packages/shopify-api/rest/admin/2024-01/recurring_application_charge.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
77
import {Session} from '../../../lib/session/session';
88
import {ApiVersion} from '../../../lib/types';
99

10-
import {Currency} from './currency';
11-
1210
interface FindArgs {
1311
session: Session;
1412
id: number | string;
@@ -32,9 +30,7 @@ interface CustomizeArgs {
3230
export class RecurringApplicationCharge extends Base {
3331
public static apiVersion = ApiVersion.January24;
3432

35-
protected static hasOne: {[key: string]: typeof Base} = {
36-
"currency": Currency
37-
};
33+
protected static hasOne: {[key: string]: typeof Base} = {};
3834
protected static hasMany: {[key: string]: typeof Base} = {};
3935
protected static paths: ResourcePath[] = [
4036
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
@@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
124120
public capped_amount: string | number | null;
125121
public confirmation_url: string | null;
126122
public created_at: string | null;
127-
public currency: Currency | null | {[key: string]: any};
123+
public currency: string | null;
128124
public id: number | null;
129125
public name: string | null;
130126
public price: string | number | null;

‎packages/shopify-api/rest/admin/2024-04/recurring_application_charge.ts‎

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,6 @@ import {ResourcePath, ResourceNames} from '../../types';
77
import {Session} from '../../../lib/session/session';
88
import {ApiVersion} from '../../../lib/types';
99

10-
import {Currency} from './currency';
11-
1210
interface FindArgs {
1311
session: Session;
1412
id: number | string;
@@ -32,9 +30,7 @@ interface CustomizeArgs {
3230
export class RecurringApplicationCharge extends Base {
3331
public static apiVersion = ApiVersion.April24;
3432

35-
protected static hasOne: {[key: string]: typeof Base} = {
36-
"currency": Currency
37-
};
33+
protected static hasOne: {[key: string]: typeof Base} = {};
3834
protected static hasMany: {[key: string]: typeof Base} = {};
3935
protected static paths: ResourcePath[] = [
4036
{"http_method": "delete", "operation": "delete", "ids": ["id"], "path": "recurring_application_charges/<id>.json"},
@@ -124,7 +120,7 @@ export class RecurringApplicationCharge extends Base {
124120
public capped_amount: string | number | null;
125121
public confirmation_url: string | null;
126122
public created_at: string | null;
127-
public currency: Currency | null | {[key: string]: any};
123+
public currency: string | null;
128124
public id: number | null;
129125
public name: string | null;
130126
public price: string | number | null;

0 commit comments

Comments
 (0)