Cleanup: remove redundant @.. broadcast=false usage

Author: Harsh Singh

lib/OrdinaryDiffEqSDIRK/src/generic_imex_perform_step.jl

@@ -231,22 +231,22 @@ end
         f_impl(zs[1], integrator.uprev, p, integrator.t)
         zs[1] .*= dt
     else
-        @.. broadcast = false zs[1] = dt * integrator.fsalfirst
+        @..zs[1] = dt * integrator.fsalfirst
     end
 
     if integrator.f isa SplitFunction
-        @.. broadcast = false ks[1] = dt * integrator.fsalfirst - zs[1]
+        @..ks[1] = dt * integrator.fsalfirst - zs[1]
     end
 
     for i in 2:s
-        @.. broadcast = false tmp = uprev
+        @..tmp = uprev
         for j in 1:(i - 1)
-            @.. broadcast = false tmp += Ai[i, j] * zs[j]
+            @..tmp += Ai[i, j] * zs[j]
         end
 
         if integrator.f isa SplitFunction
             for j in 1:(i - 1)
-                @.. broadcast = false tmp += Ae[i, j] * ks[j]
+                @..tmp += Ae[i, j] * ks[j]
             end
         end
 
@@ -255,7 +255,7 @@ end
         elseif α !== nothing && !iszero(α[i, 1])
             fill!(zs[i], zero(eltype(u)))
             for j in 1:(i - 1)
-                @.. broadcast = false zs[i] += α[i, j] * zs[j]
+                @..zs[i] += α[i, j] * zs[j]
             end
         else
             fill!(zs[i], zero(eltype(u)))
@@ -271,34 +271,34 @@ end
         end
 
         if integrator.f isa SplitFunction && i < s
-            @.. broadcast = false u = tmp + γ * zs[i]
+            @..u = tmp + γ * zs[i]
             f2(ks[i], u, p, t + c[i] * dt)
             ks[i] .*= dt
             integrator.stats.nf2 += 1
         end
     end
 
-    @.. broadcast = false u = tmp + γ * zs[s]
+    @..u = tmp + γ * zs[s]
     if integrator.f isa SplitFunction
         f2(ks[s], u, p, t + dt)
         ks[s] .*= dt
         integrator.stats.nf2 += 1
-        @.. broadcast = false u = uprev
+        @..u = uprev
         for i in 1:s
-            @.. broadcast = false u += bi[i] * zs[i] + be[i] * ks[i]
+            @..u += bi[i] * zs[i] + be[i] * ks[i]
         end
     end
 
     step_limiter!(u, integrator, p, t + dt)
 
     if integrator.opts.adaptive
-        @.. broadcast = false tmp = zero(eltype(u))
+        @..tmp = zero(eltype(u))
         for i in 1:s
-            @.. broadcast = false tmp += btilde[i] * zs[i]
+            @..tmp += btilde[i] * zs[i]
         end
         if integrator.f isa SplitFunction && ebtilde !== nothing
             for i in 1:s
-                @.. broadcast = false tmp += ebtilde[i] * ks[i]
+                @..tmp += ebtilde[i] * ks[i]
             end
         end
         if isnewton(nlsolver) && alg.smooth_est
@@ -321,6 +321,6 @@ end
     if integrator.f isa SplitFunction
         integrator.f(integrator.fsallast, u, p, t + dt)
     else
-        @.. broadcast = false integrator.fsallast = zs[s] / dt
+        @..integrator.fsallast = zs[s] / dt
     end
 end

lib/OrdinaryDiffEqSDIRK/src/kencarp_kvaerno_perform_step.jl

@@ -137,7 +137,7 @@ end
         z₁ .*= dt
     else
         # FSAL Step 1
-        @.. broadcast = false z₁ = dt * integrator.fsalfirst
+        @..z₁ = dt * integrator.fsalfirst
     end
 
     ##### Step 2
@@ -146,12 +146,12 @@ end
     copyto!(z₂, z₁)
     nlsolver.z = z₂
 
-    @.. broadcast = false tmp = uprev
+    @..tmp = uprev
 
     if integrator.f isa SplitFunction
         # This assumes the implicit part is cheaper than the explicit part
-        @.. broadcast = false k1 = dt * integrator.fsalfirst - z₁
-        @.. broadcast = false tmp += ea21 * k1
+        @..k1 = dt * integrator.fsalfirst - z₁
+        @..tmp += ea21 * k1
     end
 
     nlsolver.c = c2
@@ -163,14 +163,14 @@ end
 
     if integrator.f isa SplitFunction
         z₃ .= z₂
-        @.. broadcast = false u = tmp + γ * z₂
+        @..u = tmp + γ * z₂
         f2(k2, u, p, t + c2 * dt)
         k2 .*= dt
         integrator.stats.nf2 += 1
-        @.. broadcast = false tmp = uprev + a31 * z₁ + a32 * z₂ + ea31 * k1 + ea32 * k2
+        @..tmp = uprev + a31 * z₁ + a32 * z₂ + ea31 * k1 + ea32 * k2
     else
-        @.. broadcast = false z₃ = z₂
-        @.. broadcast = false tmp = uprev + a31 * z₁ + a32 * z₂
+        @..z₃ = z₂
+        @..tmp = uprev + a31 * z₁ + a32 * z₂
     end
     nlsolver.z = z₃
 
@@ -182,34 +182,34 @@ end
 
     if integrator.f isa SplitFunction
         z₄ .= z₂
-        @.. broadcast = false u = tmp + γ * z₃
+        @..u = tmp + γ * z₃
         f2(k3, u, p, t + c3 * dt)
         k3 .*= dt
         integrator.stats.nf2 += 1
-        @.. broadcast = false tmp = uprev + a41 * z₁ + a42 * z₂ + a43 * z₃ + ea41 * k1 +
+        @..tmp = uprev + a41 * z₁ + a42 * z₂ + a43 * z₃ + ea41 * k1 +
             ea42 * k2 + ea43 * k3
     else
-        @.. broadcast = false z₄ = z₂
-        @.. broadcast = false tmp = uprev + a41 * z₁ + a42 * z₂ + a43 * z₃
+        @..z₄ = z₂
+        @..tmp = uprev + a41 * z₁ + a42 * z₂ + a43 * z₃
     end
     nlsolver.z = z₄
 
     nlsolver.c = 1
     z₄ = nlsolve!(nlsolver, integrator, cache, repeat_step)
     nlsolvefail(nlsolver) && return
 
-    @.. broadcast = false u = tmp + γ * z₄
+    @..u = tmp + γ * z₄
     if integrator.f isa SplitFunction
         f2(k4, u, p, t + dt)
         k4 .*= dt
         integrator.stats.nf2 += 1
-        @.. broadcast = false u = uprev + a41 * z₁ + a42 * z₂ + a43 * z₃ + γ * z₄ + eb1 * k1 +
+        @..u = uprev + a41 * z₁ + a42 * z₂ + a43 * z₃ + γ * z₄ + eb1 * k1 +
             eb2 * k2 + eb3 * k3 + eb4 * k4
     end
 
     if integrator.f isa SplitFunction
         integrator.f(integrator.fsallast, u, p, t + dt)
     else
-        @.. broadcast = false integrator.fsallast = z₄ / dt
+        @..integrator.fsallast = z₄ / dt
     end
 end