Fix ifelse support and update ModelingToolkit compat#54
Merged
ChrisRackauckas merged 1 commit intoSciML:masterfrom Dec 29, 2025
Merged
Conversation
This PR fixes issue SciML#36 by: 1. Adding an `ifelse` helper function definition in MATLAB - MATLAB doesn't have a built-in `ifelse` function, but Symbolics.jl generates code using `ifelse(cond, a, b)` for the MATLAB target - We now define `ifelse = @(cond, a, b) cond .* a + ~cond .* b;` before evaluating the generated MATLAB code 2. Updating ModelingToolkit compat to support versions 8, 9, 10, 11 - The original error "TypeError: non-boolean (Num) used in boolean context" was fixed in newer ModelingToolkit/Symbolics versions - Added compatibility shim for the `states` -> `unknowns` API change Fixes SciML#36 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Author
CI Failure AnalysisThe CI failure is NOT related to my changes. The Downgrade workflow is failing due to a dependency resolution issue: Looking at recent CI runs on master, the same failure occurs:
This appears to be a pre-existing CI configuration issue with the The actual code changes are:
These changes are straightforward and syntactically correct (verified via |
This was referenced Dec 29, 2025
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #36 by addressing two related problems:
Added
ifelsehelper function for MATLABifelsefunction, butSymbolics.jlgenerates code usingifelse(cond, a, b)for theMATLABTarget()ifelse = @(cond, a, b) cond .* a + ~cond .* b;in MATLAB before evaluating the generated codeifelseexpressions (likeifelse(a > 0, -a, a)) to work correctlyUpdated ModelingToolkit compat to support versions 8, 9, 10, 11
TypeError: non-boolean (Num) used in boolean contextwas fixed in newer ModelingToolkit/Symbolics versionsstates->unknownsAPI rename (v9+)Background
The original issue used this MWE:
Which failed with
TypeError: non-boolean (Num) used in boolean context.Test plan
cc @ChrisRackauckas
🤖 Generated with Claude Code