Skip to content

Commit 87cf0d5

Browse files
committed
Use dG_group=0.586 kcal/mol in uncertainty tool
This value was fitted to median group additivity errors for 564 species with quality thermo libraries See: https://github.com/comocheng/uncertainty_estimator/blob/main/uncertainty_tool_dev/demos/quadrature/specific_examples.ipynb
1 parent 1424ba6 commit 87cf0d5

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

rmgpy/tools/uncertainty.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class ThermoParameterUncertainty(object):
4343
This class is an engine that generates the species uncertainty based on its thermo sources.
4444
"""
4545

46-
def __init__(self, dG_library=1.5, dG_QM=3.0, dG_GAV=1.5, dG_group=0.316, dG_ADS_correction=6.918, dG_surf_lib=6.918):
46+
def __init__(self, dG_library=1.5, dG_QM=3.0, dG_GAV=1.5, dG_group=0.586, dG_ADS_correction=6.918, dG_surf_lib=6.918):
4747
"""
4848
Initialize the different uncertainties dG_library, dG_QM, dG_GAV, and dG_other with set values
4949
in units of kcal/mol.

test/rmgpy/tools/uncertaintyTest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -169,7 +169,7 @@ def test_uncertainty_assignment(self):
169169

170170
np.testing.assert_allclose(
171171
thermo_unc,
172-
[1.5, 1.5, 1.7745, 1.7461, 2.1447, 1.5, 1.6879, 1.7173, 1.7745, 1.7461, 1.7745, 1.7461, 1.7745, 1.5, 2.1447, 1.6879, 1.5, 1.7745, 1.6277, 1.6581, 1.6581, 1.6879, 1.5967, 1.6277, 1.6277],
172+
[1.5, 1.5, 2.34307, 2.26495, 2.20454, 1.5, 2.1, 2.18403, 2.34307, 2.26495, 2.34307, 2.26495, 2.34307, 1.5, 2.20454, 2.1, 1.5, 2.34307, 1.92094, 2.01246, 2.01246, 2.1, 1.82483, 1.92094, 1.92094],
173173
rtol=1e-4,
174174
)
175175
np.testing.assert_allclose(

0 commit comments

Comments
 (0)