Skip to content

Commit 16c0013

Browse files
author
gabriel
committed
remove test unique with nulls
1 parent f0e9263 commit 16c0013

1 file changed

Lines changed: 0 additions & 16 deletions

File tree

tests/schema/test_validate.py

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -291,22 +291,6 @@ def test_multiple_unique_columns_both_invalid(
291291
assert not MultiUniqueSchema.is_valid(df)
292292

293293

294-
@pytest.mark.parametrize("df_type", [pl.DataFrame, pl.LazyFrame])
295-
@pytest.mark.parametrize("eager", [True, False])
296-
def test_nullable_unique_with_nulls(
297-
df_type: type[pl.DataFrame] | type[pl.LazyFrame], eager: bool
298-
) -> None:
299-
# Multiple nulls should NOT cause uniqueness failure (SQL semantics)
300-
df = df_type({"a": [1, 2, 3], "b": [None, None, "z"]})
301-
# This should fail because is_duplicated() considers nulls as duplicates
302-
# Note: This tests current behavior - in SQL, multiple NULLs are allowed in UNIQUE columns
303-
with pytest.raises(
304-
ValidationError if eager else plexc.ComputeError,
305-
match=r"1 rules failed validation",
306-
):
307-
_validate_and_collect(NullableUniqueSchema, df, eager=eager)
308-
309-
310294
def test_unique_columns_method() -> None:
311295
assert UniqueSchema.unique_columns() == ["email"]
312296
assert MultiUniqueSchema.unique_columns() == ["a", "b"]

0 commit comments

Comments
 (0)