test: expand upgrade cli integration coverage

Author: swj9707

act_operator/act_operator/tests/integration/test_cli.py

@@ -111,50 +111,38 @@ def test_init_derives_act_name_from_path(tmp_path: Path) -> None:
     assert "custom-act" in _read(project_pyproject)
 
 
-def _create_sample_project(tmp_path: Path, lang: str = "en") -> Path:
-    """Helper to scaffold a sample Act project for testing."""
-    target_dir = tmp_path / "sample-act"
-    result = runner.invoke(
-        app,
-        [
-            "--path",
-            str(target_dir),
-            "--act-name",
-            "Sample Act",
-            "--cast-name",
-            "Primary Cast",
-            "--lang",
-            lang,
-        ],
-    )
-    assert result.exit_code == 0, result.stdout
-    return target_dir
-
-
 def test_upgrade_replaces_skills(tmp_path: Path) -> None:
-    target_dir = _create_sample_project(tmp_path)
+    """Test that `act upgrade` restores scaffolded skills after local corruption."""
+    # Given a valid Act project with a corrupted skill file
+    target_dir = _create_project(tmp_path)
     skill_file = target_dir / ".claude" / "skills" / "testing-cast" / "SKILL.md"
     assert skill_file.exists()
 
-    # Corrupt a skill file
     original = _read(skill_file)
     skill_file.write_text("corrupted content", encoding="utf-8")
     assert _read(skill_file) == "corrupted content"
 
-    # Upgrade should restore it
+    # When the upgrade command is executed
     result = runner.invoke(app, ["upgrade", "--path", str(target_dir)])
     combined = (result.stdout or "") + (result.stderr or "")
+
+    # Then the original scaffold content should be restored
     assert result.exit_code == 0, combined
     assert "upgraded successfully" in combined
     assert _read(skill_file) == original
 
 
 def test_upgrade_creates_backup(tmp_path: Path) -> None:
-    target_dir = _create_sample_project(tmp_path)
+    """Test that `act upgrade` creates a backup of the existing skills directory."""
+    # Given a valid Act project with scaffolded skills
+    target_dir = _create_project(tmp_path)
     skills_dir = target_dir / ".claude" / "skills"
     assert skills_dir.exists()
 
+    # When the upgrade command is executed
     result = runner.invoke(app, ["upgrade", "--path", str(target_dir)])
+
+    # Then the previous skills should exist in .claude/skills.bak
     assert result.exit_code == 0, result.stdout
 
     backup_dir = target_dir / ".claude" / "skills.bak"
@@ -163,13 +151,68 @@ def test_upgrade_creates_backup(tmp_path: Path) -> None:
 
 
 def test_upgrade_fails_on_invalid_project(tmp_path: Path) -> None:
+    """Test that `act upgrade` fails for paths that are not valid Act projects."""
+    # Given a directory that is not an Act project
     invalid_dir = tmp_path / "not-a-project"
     invalid_dir.mkdir()
 
+    # When the upgrade command is executed against that path
     result = runner.invoke(app, ["upgrade", "--path", str(invalid_dir)])
+
+    # Then the command should fail
     assert result.exit_code != 0
 
 
+def test_upgrade_detects_korean_language_from_readme(tmp_path: Path) -> None:
+    """Test that `act upgrade` reports Korean when the project README is Korean."""
+    # Given a Korean-language Act project
+    target_dir = _create_project(tmp_path, lang="kr")
+
+    # When the upgrade command is executed
+    result = runner.invoke(app, ["upgrade", "--path", str(target_dir)])
+    combined = (result.stdout or "") + (result.stderr or "")
+
+    # Then the upgrade summary should report the detected Korean language
+    assert result.exit_code == 0, combined
+    assert "한국어" in combined
+
+
+def test_upgrade_replaces_existing_backup_directory(tmp_path: Path) -> None:
+    """Test that `act upgrade` replaces an existing skills backup with a fresh one."""
+    # Given a valid Act project and an existing stale backup directory
+    target_dir = _create_project(tmp_path)
+    backup_dir = target_dir / ".claude" / "skills.bak"
+    backup_dir.mkdir(parents=True)
+    stale_file = backup_dir / "stale.txt"
+    stale_file.write_text("old backup", encoding="utf-8")
+
+    # When the upgrade command is executed
+    result = runner.invoke(app, ["upgrade", "--path", str(target_dir)])
+
+    # Then the stale backup should be replaced by the new backup contents
+    assert result.exit_code == 0, result.stdout
+    assert backup_dir.exists()
+    assert not stale_file.exists()
+    assert (backup_dir / "testing-cast").exists()
+
+
+def test_upgrade_succeeds_with_malformed_langgraph(tmp_path: Path) -> None:
+    """Test that `act upgrade` falls back safely when langgraph.json is malformed."""
+    # Given a valid Act project with an invalid langgraph.json file
+    target_dir = _create_project(tmp_path)
+    langgraph_file = target_dir / "langgraph.json"
+    langgraph_file.write_text("{ invalid json", encoding="utf-8")
+
+    # When the upgrade command is executed
+    result = runner.invoke(app, ["upgrade", "--path", str(target_dir)])
+    combined = (result.stdout or "") + (result.stderr or "")
+
+    # Then the upgrade should still succeed using the fallback cast context
+    assert result.exit_code == 0, combined
+    assert "upgraded successfully" in combined
+    assert (target_dir / ".claude" / "skills").exists()
+
+
 def test_init_aborts_on_non_empty_dir(tmp_path: Path) -> None:
     """Test that project creation aborts when the target directory is not empty."""
     # Given a target directory that already contains files