Skip to content

Allow using CairoMakie or GLMakie using the menu()#222

Open
ufechner7 wants to merge 29 commits intomainfrom
cairo
Open

Allow using CairoMakie or GLMakie using the menu()#222
ufechner7 wants to merge 29 commits intomainfrom
cairo

Conversation

@ufechner7
Copy link
Copy Markdown
Member

@ufechner7 ufechner7 commented Apr 19, 2026

  • Add CairoMakie to examples/Project.toml
  • Add the menu entries CairoMakie!.activate() and GLMakie.activate()
  • Use pdf as format for saving plots if CairoMakie is activated
  • Create the output folder in the install script
  • Use the output folder in all examples as folder to store plots
  • Santinize the file names to use _ instead of space
  • Santinize the file manes to use pct instead of %
  • Update docu
  • Add tests

@ufechner7 ufechner7 marked this pull request as draft April 19, 2026 12:21
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ufechner7 ufechner7 marked this pull request as ready for review April 19, 2026 19:05
@ufechner7 ufechner7 requested a review from Copilot April 19, 2026 19:05
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the examples and plotting helpers to support switching between GLMakie and CairoMakie via the examples/menu.jl menu, and standardizes plot output handling (default formats, output directory, and filename sanitization).

Changes:

  • Add CairoMakie to the examples environment and provide menu options to activate GLMakie or CairoMakie at runtime.
  • Make Makie save_plot choose a backend-aware default file extension and sanitize output filenames.
  • Route example outputs to a shared output/ directory and ensure it’s created during installation.

Reviewed changes

Copilot reviewed 12 out of 14 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
ext/VortexStepMethodMakieExt.jl Backend-aware default data_type, plus filename sanitization for Makie saves.
ext/VortexStepMethodControlPlotsExt.jl Filename sanitization for ControlPlots saves.
examples/menu.jl Adds CairoMakie dependency and menu entries to activate plotting backends.
examples/*.jl Standardize output directory usage and saving toggles across examples.
examples/Project.toml Adds CairoMakie to the examples project.
bin/install Creates output/ directory during installation.
docs/src/examples.md Adds backend comparison documentation.
NEWS.md Notes the new menu backend selection feature.
.gitignore Ignores output directories.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread docs/src/examples.md
Comment thread ext/VortexStepMethodMakieExt.jl Outdated
Comment thread ext/VortexStepMethodMakieExt.jl
Comment thread examples/rectangular_wing.jl Outdated
Comment thread examples/stall_model.jl Outdated
Comment thread examples/ram_air_kite.jl Outdated
Comment thread examples/V3_kite.jl Outdated
@ufechner7 ufechner7 added the enhancement New feature or request label Apr 19, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 13 out of 15 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/plotting/test_plotting.jl Outdated
@ufechner7 ufechner7 requested a review from 1-Bart-1 April 20, 2026 04:58
Comment thread docs/src/examples.md Outdated
Comment thread docs/src/examples.md Outdated
Comment thread docs/src/examples.md Outdated
@ufechner7 ufechner7 requested a review from 1-Bart-1 April 20, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants