Improve Performance of the Model Constructor

[Yuri05]

When profiling a single PKSim.CLI.exe call in "qualification mode without running simulations" (called like below): the top path in CPU utilization (35%) is ModelConstructor.CreateModelFrom():

PKSim.CLI.exe qualification -i C:\re_input\temp\Mefenamic_acid-Dapagliflozin-DDI\config.json -l C:\\re_input\temp\Mefenamic_acid-Dapagliflozin-DDI\log.txt --logLevel Information

[msevestre]

@Yuri05 Isn't expected?

[msevestre]

Or are you saying it's only 35% and we should investigate where the rest goes?
I would have expected 70% to be model construction. The rest does virtually nothing

[Yuri05]

Or are you saying it's only 35% and we should investigate where the rest goes?

No, I'm saying that those 35% should be checked for optimizations.
In the 1st iteration I would check if in the "qualification" mode only required parts of the snapshot are loaded (e.g. no PIs and only the simulations listed in config.json). Then think what else could be optimized.

Then (but it's not model constructor anymore, so not part of this issue) I would try to understand what those 20% in ntdll mean.

[msevestre]

How many simulations do you have in this project and how much time does it take? Just percentage is not enough IMO to know if this worth investigating

[Yuri05]

How many simulations do you have in this project and how much time does it take? Just percentage is not enough IMO to know if this worth investigating

This project has only 2 simulations and runs in 1:40 or so locally.
But the point is, that the qualification runner takes now 3 hours for the DDI-CYP3A4 quali plan when running on GitHub hosted runners, meaning that model constructor part takes more than an hour (assuming the same percentage of time).
This time can be hopefully also reduced by Open-Systems-Pharmacology/QualificationRunner#173

[Yuri05]

The hot path is FormulaTask.ExpandDynamicFormulaIn.
VS Profile Session log