Skip to content

Commit 8a85e1b

Browse files
2726 newly created curve chart curves do not match the curve editor (#2727)
* #2726 prevent different color on editor * #2726 remove unused * #2726 format fix
1 parent 25d84fb commit 8a85e1b

1 file changed

Lines changed: 9 additions & 5 deletions

File tree

src/OSPSuite.Presentation/Presenters/Charts/ChartEditorPresenter.cs

Lines changed: 9 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -421,6 +421,7 @@ private void updateColumnUsedProperty(IReadOnlyList<DataColumn> columns, bool us
421421
else
422422
Chart.RemoveCurvesForColumn(column);
423423
});
424+
424425
}
425426

426427
public void ApplyAllColumnSettings() => _presentersWithColumnSettings.Each(x => x.ApplyAllColumnSettings());
@@ -676,19 +677,22 @@ public Curve AddCurveForColumn(DataColumn dataColumn, CurveOptions defaultCurveO
676677
{
677678
var (exists, curve) = createAndConfigureCurve(dataColumn, defaultCurveOptions);
678679

679-
//Make sure color and style are updated to match linked data to simulation or observed data
680-
Chart.UpdateCurveColorAndStyle(curve, dataColumn, AllDataColumns, isLinkedDataToSimulation);
680+
if (exists)
681+
{
682+
if (isLinkedDataToSimulation)
683+
Chart.UpdateCurveColorAndStyle(curve, dataColumn, AllDataColumns, isLinkedDataToSimulation: true);
684+
return curve;
685+
}
681686

682-
if (exists) return curve;
687+
Chart.UpdateCurveColorAndStyle(curve, dataColumn, AllDataColumns, isLinkedDataToSimulation);
683688

684689
if (defaultCurveOptions != null)
685690
curve.CurveOptions.UpdateFrom(defaultCurveOptions);
686691

687692
Chart.AddCurve(curve);
688-
689693
return curve;
690694
}
691-
695+
692696
private (bool exists, Curve curve) createAndConfigureCurve(DataColumn dataColumn, CurveOptions defaultCurveOptions)
693697
{
694698
var curve = Chart.FindCurveWithSameData(dataColumn.BaseGrid, dataColumn);

0 commit comments

Comments
 (0)