Merge remote-tracking branch 'origin/main' into iamquang95/implement-eth2util-signing

Author: iamquang95

Cargo.toml

@@ -129,6 +129,7 @@ cast_precision_loss = "deny"
 cast_sign_loss = "deny"
 needless_return = "deny"
 panicking_overflow_checks = "deny"
+redundant_test_prefix = "deny"
 unwrap_used = "deny"
 
 # Optimize crypto dependencies in test builds for faster tests

crates/app/src/featureset.rs

@@ -295,7 +295,7 @@ mod tests {
     use super::*;
 
     #[test]
-    fn test_all_feature_status() {
+    fn all_feature_status() {
         let featureset = FeatureSet::new();
 
         let features = Feature::all();
@@ -312,7 +312,7 @@ mod tests {
     }
 
     #[test]
-    fn test_status_display() {
+    fn status_display() {
         assert_eq!(Status::Disable.to_string(), "disable");
         assert_eq!(Status::Alpha.to_string(), "alpha");
         assert_eq!(Status::Beta.to_string(), "beta");
@@ -322,7 +322,7 @@ mod tests {
     }
 
     #[test]
-    fn test_custom_enabled_all() {
+    fn custom_enabled_all() {
         let featureset = FeatureSet::new();
 
         // Initially no custom enabled features
@@ -343,7 +343,7 @@ mod tests {
     }
 
     #[test]
-    fn test_config() {
+    fn config() {
         let featureset = FeatureSet::new();
         assert_eq!(featureset.min_status, Status::Stable);
 
@@ -359,7 +359,7 @@ mod tests {
     }
 
     #[test]
-    fn test_enable_feature() {
+    fn enable_feature() {
         let featureset = FeatureSet::new();
 
         // Initially disabled (MockAlpha is Alpha status, min_status is Stable)
@@ -377,7 +377,7 @@ mod tests {
     }
 
     #[test]
-    fn test_disable_feature() {
+    fn disable_feature() {
         // First create with a stable feature (EagerDoubleLinear is Stable by default)
         let featureset = FeatureSet::from_config(Config {
             min_status: Status::Stable,
@@ -404,7 +404,7 @@ mod tests {
     // Verifies FeatureSet::new() matches Go's
     // featureset.Init(featureset.DefaultConfig()) Reference:
     // app/featureset/featureset.go and app/featureset/config.go
-    fn test_default_matches_go_implementation() {
+    fn default_matches_go_implementation() {
         // Verify Config::default() matches Go's DefaultConfig()
         let config = Config::default();
         assert_eq!(config.min_status, Status::Stable);
@@ -446,7 +446,7 @@ mod tests {
     }
 
     #[test]
-    fn test_enable_gnosis_block_hotfix_if_not_disabled() {
+    fn enable_gnosis_block_hotfix_if_not_disabled() {
         // Test method when not disabled explicitly
         let config = Config::default();
         let mut featureset =

crates/app/src/obolapi/client.rs

@@ -218,7 +218,7 @@ mod tests {
     }
 
     #[test]
-    fn test_new_client_valid_url() {
+    fn new_client_valid_url() {
         assert!(
             Client::new(
                 "https://api.obol.tech",
@@ -231,12 +231,12 @@ mod tests {
     }
 
     #[test]
-    fn test_new_client_invalid_url() {
+    fn new_client_invalid_url() {
         assert!(Client::new("not-a-url", ClientOptions::default()).is_err());
     }
 
     #[test]
-    fn test_base_url_normalization() {
+    fn base_url_normalization() {
         let c1 = Client::new("https://api.obol.tech", ClientOptions::default()).unwrap();
         assert_eq!(c1.base_url.as_str(), "https://api.obol.tech/");
 
@@ -251,7 +251,7 @@ mod tests {
     }
 
     #[test]
-    fn test_build_url_root_base() {
+    fn build_url_root_base() {
         let client = Client::new("https://api.obol.tech", ClientOptions::default()).unwrap();
         assert_eq!(
             client.build_url("definition").unwrap().as_str(),
@@ -271,7 +271,7 @@ mod tests {
     }
 
     #[test]
-    fn test_build_url_versioned_base() {
+    fn build_url_versioned_base() {
         let client = Client::new("https://api.obol.tech/v1", ClientOptions::default()).unwrap();
         assert_eq!(
             client.build_url("definition").unwrap().as_str(),
@@ -291,13 +291,13 @@ mod tests {
     }
 
     #[test]
-    fn test_launchpad_url_path() {
+    fn launchpad_url_path_works() {
         let lock = test_lock_with_hash(vec![0x12, 0x34, 0xab, 0xcd]);
         assert_eq!(launchpad_url_path(&lock), "/lock/0x1234ABCD/launchpad");
     }
 
     #[test]
-    fn test_launchpad_url_for_lock() {
+    fn launchpad_url_for_lock() {
         let lock = test_lock_with_hash(vec![0x12, 0x34, 0xab, 0xcd]);
 
         let c1 = Client::new("https://api.obol.tech", ClientOptions::default()).unwrap();

crates/app/src/obolapi/exit.rs

@@ -430,27 +430,27 @@ mod tests {
     use super::*;
 
     #[test]
-    fn test_submit_partial_exit_url() {
+    fn submit_partial_exit_url_works() {
         let url = submit_partial_exit_url("0xabcd1234");
         assert_eq!(url, "/exp/partial_exits/0xabcd1234");
     }
 
     #[test]
-    fn test_delete_partial_exit_url() {
+    fn delete_partial_exit_url_works() {
         let url = delete_partial_exit_url("0xpubkey", "0xlockhash", 5);
         assert_eq!(url, "/exp/partial_exits/0xlockhash/5/0xpubkey");
     }
 
     #[test]
-    fn test_fetch_full_exit_url() {
+    fn fetch_full_exit_url_works() {
         let url = fetch_full_exit_url("0xpubkey", "0xlockhash", 5);
         assert_eq!(url, "/exp/exit/0xlockhash/5/0xpubkey");
     }
 
     /// These test vectors were generated from Go `charon/app/obolapi` using
     /// fastssz
     #[test]
-    fn test_ssz_root_parity_exit_models() -> std::result::Result<(), Box<dyn std::error::Error>> {
+    fn ssz_root_parity_exit_models() -> std::result::Result<(), Box<dyn std::error::Error>> {
         fn decode_hex(s: &str) -> std::result::Result<Vec<u8>, hex::FromHexError> {
             hex::decode(s)
         }

crates/app/src/obolapi/helper.rs

@@ -19,31 +19,31 @@ mod tests {
     use super::*;
 
     #[test]
-    fn test_from_0x_with_prefix() {
+    fn from_0x_with_prefix() {
         let bytes = from_0x("0x1234", 2).unwrap();
         assert_eq!(bytes, vec![0x12, 0x34]);
     }
 
     #[test]
-    fn test_from_0x_without_prefix() {
+    fn from_0x_without_prefix() {
         let bytes = from_0x("1234", 2).unwrap();
         assert_eq!(bytes, vec![0x12, 0x34]);
     }
 
     #[test]
-    fn test_from_0x_empty_string() {
+    fn from_0x_empty_string() {
         let result = from_0x("", 2);
         assert!(matches!(result, Err(Error::EmptyHex)));
     }
 
     #[test]
-    fn test_from_0x_wrong_length() {
+    fn from_0x_wrong_length() {
         let result = from_0x("0x1234", 3);
         assert!(result.is_err());
     }
 
     #[test]
-    fn test_bearer_string() {
+    fn bearer_string_works() {
         let bearer = bearer_string(&[0x12, 0x34, 0xab, 0xcd]);
         assert_eq!(bearer, "Bearer 0x1234abcd");
     }

crates/app/src/privkeylock.rs

@@ -159,7 +159,7 @@ mod tests {
     use std::path::PathBuf;
 
     #[tokio::test]
-    async fn test_service() {
+    async fn service() {
         let dir = tempfile::tempdir().expect("failed to create temp dir");
         let path: PathBuf = dir.path().join("privkeylocktest");
 

crates/cli/src/commands/create_dkg.rs

@@ -576,7 +576,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_create_dkg_valid() {
+    async fn create_dkg_valid() {
         let dir = temp_dir();
         let args = CreateDkgArgs {
             output_dir: dir.path().to_path_buf(),
@@ -707,7 +707,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_dkg_cli_no_threshold() {
+    async fn dkg_cli_no_threshold() {
         let dir = temp_dir();
         let enr = "enr:-JG4QG472ZVvl8ySSnUK9uNVDrP_hjkUrUqIxUC75aayzmDVQedXkjbqc7QKyOOS71VmlqnYzri_taV8ZesFYaoQSIOGAYHtv1WsgmlkgnY0gmlwhH8AAAGJc2VjcDI1NmsxoQKwwq_CAld6oVKOrixE-JzMtvvNgb9yyI-_rwq4NFtajIN0Y3CCDhqDdWRwgg4u";
         let enrs: Vec<String> = (0..MIN_NODES).map(|_| enr.to_string()).collect();
@@ -728,7 +728,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_existing_cluster_definition() {
+    async fn existing_cluster_definition() {
         let dir = temp_dir();
         tokio::fs::write(
             dir.path().join("cluster-definition.json"),

crates/cli/src/commands/test/beacon.rs

@@ -2232,7 +2232,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_default_scenario() {
+    async fn beacon_default_scenario() {
         let server = start_healthy_mocked_beacon_node().await;
         let url = server.uri();
         let args = default_beacon_args(vec![url.clone()]);
@@ -2245,7 +2245,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_connection_refused() {
+    async fn beacon_connection_refused() {
         let port1 = 19876;
         let port2 = 19877;
         let endpoint1 = format!("http://localhost:{port1}");
@@ -2277,7 +2277,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_timeout() {
+    async fn beacon_timeout() {
         let endpoint1 = "http://localhost:19878".to_string();
         let endpoint2 = "http://localhost:19879".to_string();
         let mut args = default_beacon_args(vec![endpoint1.clone(), endpoint2.clone()]);
@@ -2295,7 +2295,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_quiet() {
+    async fn beacon_quiet() {
         let dir = tempfile::tempdir().unwrap();
         let json_path = dir.path().join("output.json");
 
@@ -2313,7 +2313,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_unsupported_test() {
+    async fn beacon_unsupported_test() {
         let args = TestBeaconArgs {
             test_config: TestConfigArgs {
                 test_cases: Some(vec!["notSupportedTest".to_string()]),
@@ -2333,7 +2333,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_custom_test_cases() {
+    async fn beacon_custom_test_cases() {
         let endpoint1 = "http://localhost:19883".to_string();
         let endpoint2 = "http://localhost:19884".to_string();
         let mut args = default_beacon_args(vec![endpoint1.clone(), endpoint2.clone()]);
@@ -2351,7 +2351,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_write_to_file() {
+    async fn beacon_write_to_file() {
         let dir = tempfile::tempdir().unwrap();
         let file_path = dir.path().join("beacon-test-output.json");
 
@@ -2377,7 +2377,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_basic_auth_with_credentials() {
+    async fn beacon_basic_auth_with_credentials() {
         let server = MockServer::start().await;
 
         Mock::given(method("GET"))
@@ -2398,7 +2398,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_beacon_basic_auth_without_credentials() {
+    async fn beacon_basic_auth_without_credentials() {
         let server = MockServer::start().await;
 
         Mock::given(method("GET"))

crates/cli/src/commands/test/helpers.rs

@@ -788,7 +788,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_write_result_to_file_creates_new_file() {
+    async fn write_result_to_file_creates_new_file() {
         let dir = tempfile::tempdir().unwrap();
         let path = dir.path().join("output.json");
 
@@ -812,7 +812,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_write_result_to_file_merges_categories() {
+    async fn write_result_to_file_merges_categories() {
         let dir = tempfile::tempdir().unwrap();
         let path = dir.path().join("output.json");
 
@@ -843,7 +843,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_write_result_to_file_overwrites_same_category() {
+    async fn write_result_to_file_overwrites_same_category() {
         let dir = tempfile::tempdir().unwrap();
         let path = dir.path().join("output.json");
 
@@ -903,7 +903,7 @@ mod tests {
 
     #[cfg(unix)]
     #[tokio::test]
-    async fn test_write_result_to_file_sets_permissions() {
+    async fn write_result_to_file_sets_permissions() {
         use std::os::unix::fs::PermissionsExt as _;
 
         let dir = tempfile::tempdir().unwrap();
@@ -917,7 +917,7 @@ mod tests {
     }
 
     #[tokio::test]
-    async fn test_write_result_to_file_all_categories() {
+    async fn write_result_to_file_all_categories() {
         let dir = tempfile::tempdir().unwrap();
         let path = dir.path().join("output.json");
 

crates/cli/src/commands/test/mev.rs

@@ -702,7 +702,7 @@ mod tests {
     use super::*;
 
     #[test]
-    fn test_format_mev_relay_name() {
+    fn format_mev_relay_name_works() {
         assert_eq!(
             format_mev_relay_name(
                 "https://0xac6e77dfe25ecd6110b8e780608cce0dab71fdd5ebea22a16c0205200f2f8e2e3ad3b71d3499c54ad14d6c21b41a37ae@boost-relay.flashbots.net"
@@ -732,7 +732,7 @@ mod tests {
     }
 
     #[test]
-    fn test_get_validator_pk_for_slot() {
+    fn get_validator_pk_for_slot_works() {
         let duties = vec![
             ProposerDutiesData {
                 pubkey: "0xabc".to_string(),