Require account-only BAL reads

Author: flcl42

src/Nethermind/Nethermind.Blockchain.Test/BlockProcessorTests.cs

@@ -278,6 +278,19 @@ public void ParallelWorldState_bal_read_budget_ignores_reads_already_in_generate
         Assert.That(act, Throws.Nothing);
     }
 
+    [Test, MaxTime(Timeout.MaxTestTime)]
+    public void ParallelWorldState_bal_validation_rejects_missing_account_only_reads()
+    {
+        ParallelWorldState stateProvider = new(TestWorldStateFactory.CreateForTest());
+        stateProvider.LoadSuggestedBlockAccessList(new BlockAccessList(), 10_000);
+        stateProvider.GeneratedBlockAccessList.IncrementBlockAccessIndex();
+        stateProvider.GeneratedBlockAccessList.AddAccountRead(TestItem.AddressA);
+
+        TestDelegate act = () => stateProvider.ValidateBlockAccessList(Build.A.BlockHeader.TestObject, 1, 10_000);
+
+        Assert.Throws<ParallelWorldState.InvalidBlockLevelAccessListException>(act);
+    }
+
     [Test, MaxTime(Timeout.MaxTestTime)]
     public void BranchProcessor_no_prewarmer_still_processes_successfully()
     {

src/Nethermind/Nethermind.State/ParallelWorldState.cs

@@ -280,7 +280,7 @@ void AdvanceSuggested()
         {
             if (suggestedHead is null)
             {
-                if (HasNoChanges(generatedHead.Value))
+                if (HasOptionalStorageReads(generatedHead.Value))
                 {
                     AdvanceGenerated();
                     continue;
@@ -320,7 +320,7 @@ void AdvanceSuggested()
             }
             else
             {
-                if (HasNoChanges(generatedHead.Value))
+                if (HasOptionalStorageReads(generatedHead.Value))
                 {
                     AdvanceGenerated();
                     continue;
@@ -367,4 +367,7 @@ private static bool HasNoChanges(in ChangeAtIndex c)
             c.NonceChange is null &&
             c.CodeChange is null &&
             !c.SlotChanges.GetEnumerator().MoveNext();
+
+    private static bool HasOptionalStorageReads(in ChangeAtIndex c)
+        => HasNoChanges(c) && c.Reads > 0;
 }