-
-
Notifications
You must be signed in to change notification settings - Fork 365
Output has non es5 keywords. #494
Copy link
Copy link
Closed
Labels
PendingPending to be confirmed by user/author for some check/update/implementationPending to be confirmed by user/author for some check/update/implementation
Metadata
Metadata
Assignees
Labels
PendingPending to be confirmed by user/author for some check/update/implementationPending to be confirmed by user/author for some check/update/implementation
Description
library contains non es5 output.
Seems like this library doesn't go through the build process actually before being published.
Otherwise babel (which doesn't have a target or a browserslist by the way) will compile to es5 by default.
My suggested solution is to run the library through a build process using babel and add a
.browserslistrcfile to specify the target explicitly rather than relying on convention and preset-env's default configuration.preferably rollup which is more tailored towards libraries and has es modules export capabilities (webpack 5 has them too but it's new).
Input
None
Code
None
Output
Non es5 keywords like
constexist in library output.expected output
output should be es5 without any const, let etc...
Or, if you decide not to support older browsers, please specify so in the documentation.
Would you like to work on this issue?
Bookmark this repository for further updates.