Skip to content

Commit 243e2b3

Browse files
author
echo724
committed
tests: modify tests
1 parent cc99379 commit 243e2b3

File tree

4 files changed

+19
-18
lines changed

4 files changed

+19
-18
lines changed

duva/tests/cluster_ops/test_cluster_meet.rs

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,8 @@ fn run_cluster_meet(append_only: bool) -> anyhow::Result<()> {
3030
while until > std::time::Instant::now() {
3131
let res = client_handler.send_and_get_vec("cluster info", 1);
3232
if res.contains(&"cluster_known_nodes:3".to_string()) {
33-
assert_eq!(client_handler.send_and_get("role"), "leader");
33+
let role_response = client_handler.send_and_get_vec("role", 2);
34+
assert!(role_response.contains(&format!("127.0.0.1:{}:{}", env3.port, "leader")));
3435
success_cnt += 1;
3536
break;
3637
}
@@ -42,7 +43,8 @@ fn run_cluster_meet(append_only: bool) -> anyhow::Result<()> {
4243
while until > std::time::Instant::now() {
4344
let res = replica_handler.send_and_get_vec("cluster info", 1);
4445
if res.contains(&"cluster_known_nodes:3".to_string()) {
45-
assert_eq!(replica_handler.send_and_get("role"), "follower");
46+
let role_response = client_handler.send_and_get_vec("role", 2);
47+
assert!(role_response.contains(&format!("127.0.0.1:{}:{}", env4.port, "follower")));
4648
success_cnt += 1;
4749
break;
4850
}

duva/tests/cluster_ops/test_lazy_discovery.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,9 @@ fn run_lazy_discovery_of_leader(with_append_only: bool) -> anyhow::Result<()> {
2424
assert_eq!(p1_h.send_and_get(format!("REPLICAOF 127.0.0.1 {}", &env2.port)), "OK");
2525

2626
// THEN
27-
assert_eq!(p1_h.send_and_get("role"), "follower");
28-
assert_eq!(p2_h.send_and_get("role"), "leader");
27+
let role_response = p1_h.send_and_get_vec("role", 2);
28+
assert!(role_response.contains(&format!("127.0.0.1:{}:{}", p1.port, "follower")));
29+
assert!(role_response.contains(&format!("127.0.0.1:{}:{}", env2.port, "leader")));
2930

3031
// * Following is required to test replicaof successuflly update topology changes
3132
p1.terminate()?;

duva/tests/cluster_ops/test_reconnection_on_reboot.rs

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -24,13 +24,13 @@ fn run_reconnection_on_reboot(with_append_only: bool) -> anyhow::Result<()> {
2424
//THEN
2525

2626
let mut cli_to_p2 = Client::new(p2.port);
27-
let p2_role = cli_to_p2.send_and_get("ROLE");
27+
let p2_role = cli_to_p2.send_and_get_vec("ROLE", 2);
2828

2929
let mut cli_to_p1 = Client::new(p1.port);
30-
let p1_role = cli_to_p1.send_and_get("ROLE");
30+
let p1_role = cli_to_p1.send_and_get_vec("ROLE", 2);
3131

32-
assert_eq!(p2_role, "follower");
33-
assert_eq!(p1_role, "leader");
32+
assert!(p2_role.contains(&format!("127.0.0.1:{}:{}", p2.port, "follower")));
33+
assert!(p1_role.contains(&format!("127.0.0.1:{}:{}", p1.port, "leader")));
3434

3535
// Check that the values are still there
3636
assert_eq!(cli_to_p2.send_and_get("GET x"), "value1");

duva/tests/replication_ops/test_leader_election.rs

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -43,16 +43,15 @@ fn run_set_twice_after_election(with_append_only: bool) -> anyhow::Result<()> {
4343

4444
panic_if_election_not_done(follower_p1.port, follower_p2.port);
4545

46-
let res = h1.send_and_get("role");
47-
let res2 = h2.send_and_get("role");
46+
let res = h1.send_and_get_vec("role", 3);
4847

49-
if res.contains(&"leader".to_string()) {
48+
if res.contains(&format!("127.0.0.1:{}:{}", follower_p1.port, "leader")) {
5049
// THEN - one of the replicas should become the leader
5150
assert_eq!(h1.send_and_get("set 1 2"), "OK");
5251
assert_eq!(h1.send_and_get("set 2 3"), "OK");
5352
}
5453

55-
if res2 == "leader" {
54+
if res.contains(&format!("127.0.0.1:{}:{}", follower_p2.port, "leader")) {
5655
// THEN - one of the replicas should become the leader
5756
assert_eq!(h2.send_and_get("set 1 2"), "OK");
5857
assert_eq!(h2.send_and_get("set 2 3"), "OK");
@@ -112,22 +111,21 @@ fn panic_if_election_not_done(port1: u16, port2: u16) {
112111
let mut first_election_cnt = 0;
113112
let mut flag = false;
114113
let mut h1 = Client::new(port1);
115-
let mut h2 = Client::new(port2);
116114

117115
let start = std::time::Instant::now();
118116
while first_election_cnt < 50 {
119-
let res = h1.send_and_get("role");
120-
let res2 = h2.send_and_get("role");
117+
let res = h1.send_and_get_vec("role", 2);
121118
println!(
122-
"[{}ms] Poll {}: port1={} port2={} res1={} res2={}",
119+
"[{}ms] Poll {}: port1={} port2={} res={:?}",
123120
start.elapsed().as_millis(),
124121
first_election_cnt,
125122
port1,
126123
port2,
127124
res,
128-
res2
129125
);
130-
if res == "leader" || res2 == "leader" {
126+
if res.contains(&format!("127.0.0.1:{}:{}", port1, "leader"))
127+
|| res.contains(&format!("127.0.0.1:{}:{}", port2, "leader"))
128+
{
131129
flag = true;
132130
break;
133131
}

0 commit comments

Comments
 (0)