Skip to content

Commit 5197b28

Browse files
authored
Merge pull request #179 from Maxteabag/worktree-fix-d1-query-endpoint
Fix D1 adapter hitting wrong endpoint (/execute -> /query)
2 parents 726a7ab + 085f52f commit 5197b28

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

sqlit/domains/connections/providers/d1/adapter.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -125,8 +125,8 @@ def get_databases(self, conn: D1Connection) -> list[str]:
125125
return [db["name"] for db in databases if "name" in db]
126126

127127
def _execute(self, conn: D1Connection, query: str) -> dict[str, Any]:
128-
"""Internal method to run a command on the D1 execute endpoint."""
129-
api_url = f"{self._api_base_url()}/client/v4/accounts/{conn.account_id}/d1/database/{conn.database_id}/execute"
128+
"""Internal method to run a command on the D1 query endpoint."""
129+
api_url = f"{self._api_base_url()}/client/v4/accounts/{conn.account_id}/d1/database/{conn.database_id}/query"
130130
response = conn.session.post(api_url, json={"sql": query})
131131
response.raise_for_status()
132132
# The result is a list containing a single result object

tests/fixtures/d1.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ def create_database(self, name: str) -> None:
6363
def execute(self, db_name: str, sql: str) -> dict | None:
6464
payload = self._request(
6565
"POST",
66-
f"/client/v4/accounts/{self._account_id}/d1/database/{db_name}/execute",
66+
f"/client/v4/accounts/{self._account_id}/d1/database/{db_name}/query",
6767
{"sql": sql},
6868
)
6969
if not payload.get("success", False):

tests/fixtures/d1/index.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,7 @@ export default {
1414
}
1515

1616
const execMatch = path.match(
17-
/^\/client\/v4\/accounts\/([^/]+)\/d1\/database\/([^/]+)\/execute$/
17+
/^\/client\/v4\/accounts\/([^/]+)\/d1\/database\/([^/]+)\/query$/
1818
);
1919
if (execMatch && request.method === "POST") {
2020
let body;

0 commit comments

Comments
 (0)