Skip to content

Support for Request Contexts #64

@harmonherring

Description

@harmonherring

It doesn't look like any of these requests support caller-defined contexts. @KnutZuidema would you support it if I opened a PR that adds ...WithContext functions for all existing API requests?

For example, I'd add GetByAccountIDWithContext(ctx context.Context, ...), GetByPUUIDWithContext(ctx context.Context, ...) etc etc for summoner routes.

I'm thinking I'd bubble that context down to a duplicate Client.DoRequestWithContext(ctx context.Context, ...) that adds a context to the request with request.WithContext

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions