fix(core): detect files in nested body objects for multipart uploads

Author: Julien-R44

.changeset/deep-file-detection.md

@@ -0,0 +1,5 @@
+---
+'@tuyau/core': patch
+---
+
+Fix shallow file detection in request body. `#hasFile` now recursively checks nested objects and arrays (up to 5 levels deep) to properly detect files and switch to multipart/form-data.

packages/core/src/client/tuyau.ts

@@ -129,12 +129,15 @@ export class Tuyau<
   /**
    * Checks if an object contains any file uploads
    */
-  #hasFile(obj: Record<string, any>) {
-    if (!obj) return false
+  #hasFile(obj: Record<string, any>, depth = 0): boolean {
+    if (!obj || depth > 5) return false
 
     return Object.values(obj).some((val) => {
-      if (Array.isArray(val)) return val.some(this.#isFile)
-      return this.#isFile(val)
+      if (this.#isFile(val)) return true
+      if (Array.isArray(val)) return val.some((item) => this.#isFile(item) || (isObject(item) && this.#hasFile(item, depth + 1)))
+      if (isObject(val)) return this.#hasFile(val, depth + 1)
+
+      return false
     })
   }
 

packages/core/tests/client.spec.ts

@@ -300,6 +300,45 @@ test.group('Client | Chained', () => {
     await tuyau.api.users.store({ body: { file: blob } })
   })
 
+  test('send as form data when file is nested in object', async () => {
+    const tuyau = createTuyau({ baseUrl: 'http://localhost:3333', registry })
+
+    nock('http://localhost:3333')
+      .post('/auth/login')
+      .reply(200, { token: '123' })
+      .matchHeader('content-type', /multipart\/form-data/)
+
+    await tuyau.api.auth.login({
+      body: { email: 'foo@ok.com', password: 'foo', profile: { avatar: new File(['img'], 'avatar.png') } },
+    })
+  })
+
+  test('send as form data when file is deeply nested', async () => {
+    const tuyau = createTuyau({ baseUrl: 'http://localhost:3333', registry })
+
+    nock('http://localhost:3333')
+      .post('/auth/login')
+      .reply(200, { token: '123' })
+      .matchHeader('content-type', /multipart\/form-data/)
+
+    await tuyau.api.auth.login({
+      body: { email: 'foo@ok.com', data: { nested: { deep: { file: new File(['hello'], 'hello.txt') } } } },
+    })
+  })
+
+  test('send as form data when file is inside array of objects', async () => {
+    const tuyau = createTuyau({ baseUrl: 'http://localhost:3333', registry })
+
+    nock('http://localhost:3333')
+      .post('/auth/login')
+      .reply(200, { token: '123' })
+      .matchHeader('content-type', /multipart\/form-data/)
+
+    await tuyau.api.auth.login({
+      body: { email: 'foo@ok.com', attachments: [{ file: new File(['doc'], 'doc.pdf') }] },
+    })
+  })
+
   test('pass form data directly', async () => {
     const tuyau = createTuyau({ baseUrl: 'http://localhost:3333', registry })