try for a compat backport of JLD2#49
Closed
JonasIsensee wants to merge 1 commit intoJuliaGraphs:masterfrom
Closed
Conversation
Member
|
I created a new branch https://github.com/JuliaGraphs/MetaGraphs.jl/tree/v0.7backports Could you close this PR and make a new one against that branch? Let me know if you want the branch to branch out from a different commit. If not, please revert the breaking commits. If you have the bandwidth to help more, we are in need of more volunteer maintainers -- happy to add you. |
Member
|
this seems to be the only breaking change #40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports the JLD2 compat bound to the latest v0.6 versions.
This should not be necessary but there are downstream packages with hard to reach authors (LightOSM) which still depend on MetaGraphs v0.7 and I think it will be quicker to release a patch of MetaGraphs than to get a new LightOSM release out.
Core problem is that old JLD2 does not compile on julia v1.12 and therefore the MetaGraphs v0.7 series does not compile on v1.12 and neither do any of the downstream packages.
Actually, this PR should not point to master but to a dedicated backport branch from which we can tag a patch release.