Skip to content

Commit 9c92ee0

Browse files
committed
Merge remote-tracking branch 'refs/remotes/origin/fix/gnnlux-mooncake-skip' into fix/gnnlux-mooncake-skip
2 parents b6365c7 + 02ef760 commit 9c92ee0

File tree

6 files changed

+19
-5
lines changed

6 files changed

+19
-5
lines changed

.github/workflows/test_GNNGraphs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
- uses: julia-actions/julia-processcoverage@v1
4545
with:
4646
directories: GNNGraphs/src,GNNGraphs/ext
47-
- uses: codecov/codecov-action@v5
47+
- uses: codecov/codecov-action@v6
4848
with:
4949
token: ${{ secrets.CODECOV_TOKEN }}
5050
files: lcov.info

.github/workflows/test_GNNLux.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
- uses: julia-actions/julia-processcoverage@v1
4343
with:
4444
directories: GNNLux/src,GNNGraphs/src,GNNGraphs/ext,GNNlib/src,GNNlib/ext
45-
- uses: codecov/codecov-action@v5
45+
- uses: codecov/codecov-action@v6
4646
with:
4747
token: ${{ secrets.CODECOV_TOKEN }}
4848
files: lcov.info

.github/workflows/test_GNNlib.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ jobs:
4444
- uses: julia-actions/julia-processcoverage@v1
4545
with:
4646
directories: GNNlib/src,GNNlib/ext,GNNGraphs/src,GNNGraphs/ext
47-
- uses: codecov/codecov-action@v5
47+
- uses: codecov/codecov-action@v6
4848
with:
4949
token: ${{ secrets.CODECOV_TOKEN }}
5050
files: lcov.info

.github/workflows/test_GraphNeuralNetworks.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ jobs:
4242
- uses: julia-actions/julia-processcoverage@v1
4343
with:
4444
directories: GraphNeuralNetworks/src,GNNGraphs/src,GNNGraphs/ext,GNNlib/src,GNNlib/ext
45-
- uses: codecov/codecov-action@v5
45+
- uses: codecov/codecov-action@v6
4646
with:
4747
token: ${{ secrets.CODECOV_TOKEN }}
4848
files: lcov.info

GNNGraphs/src/transform.jl

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -65,7 +65,7 @@ end
6565

6666
function remove_self_loops(g::GNNGraph{<:ADJMAT_T})
6767
@assert isempty(g.edata)
68-
A = g.graph
68+
A = copy(g.graph)
6969
A[diagind(A)] .= 0
7070
if A isa AbstractSparseMatrix
7171
dropzeros!(A)

GNNGraphs/test/transform.jl

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -376,6 +376,20 @@ end
376376
@test size(get_edge_weight(g2)) == (g2.num_edges,)
377377
@test size(g2.edata.e1) == (3, g2.num_edges)
378378
@test size(g2.edata.e2) == (g2.num_edges,)
379+
else
380+
A = [1 1 0
381+
0 1 1
382+
1 0 0]
383+
A_no_loops = [0 1 0
384+
0 0 1
385+
1 0 0]
386+
g = GNNGraph(A; graph_type = GRAPH_T)
387+
g2 = remove_self_loops(g)
388+
389+
@test Matrix(adjacency_matrix(g)) == A
390+
@test Matrix(adjacency_matrix(g2)) == A_no_loops
391+
@test g2.num_edges == count(!iszero, A_no_loops)
392+
@test g.graph !== g2.graph
379393
end
380394
end
381395
end

0 commit comments

Comments
 (0)