more flexible + better benchmarking + Julia 1.x compliant#59
Closed
pdimens wants to merge 2 commits intoJuliaAstro:masterfrom
pdimens:master
Closed
more flexible + better benchmarking + Julia 1.x compliant#59pdimens wants to merge 2 commits intoJuliaAstro:masterfrom pdimens:master
pdimens wants to merge 2 commits intoJuliaAstro:masterfrom
pdimens:master
Conversation
This PR uses the convert_coord() function in pdimens/PopGen.jl to make ten() faster and more flexible. Flexible in the sense that it can tolerate cardinal directions as well, such as "11 32 42S". Before: julia> @Btime ten("-10 26") 2.135 μs (33 allocations: 1.52 KiB)-10.433333333333334 julia> @Btime ten("-10 26") 1.571 μs (18 allocations: 928 bytes)-10.433333333333334
giordano
reviewed
Jun 20, 2020
Member
|
The forked repository seems to have been deleted, and the changes (at least the Julia 1 compliance) seems to have been superseded. Closing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR uses the
convert_coord()function in pdimens/PopGen.jl to make ten() faster and more flexible. Flexible in the sense that it can tolerate cardinal directions as well, such as "11 32 42S". In the current form,tenuses a deprecated version ofreplaceand will not function for julia 1.xBefore:
After: