Code review

Author: Keavon

editor/src/messages/portfolio/portfolio_message_handler.rs

@@ -472,6 +472,12 @@ impl MessageHandler<PortfolioMessage, PortfolioMessageContext<'_>> for Portfolio
 				let Some(source_state) = self.workspace_panel_layout.panel_group(source_group) else { return };
 				let Some(panel_type) = source_state.active_panel_type() else { return };
 
+				// Validate that the target group exists before modifying the source
+				if self.workspace_panel_layout.panel_group(target_group).is_none() {
+					log::error!("Target panel group {target_group:?} not found");
+					return;
+				}
+
 				// Destroy layouts for the moved panel (so backend and frontend start in sync when it remounts)
 				// and for the panel that was previously active in the target panel group (it will be displaced by the incoming tab)
 				Self::destroy_panel_layouts(panel_type, responses);

editor/src/messages/portfolio/utility_types.rs

@@ -418,6 +418,9 @@ impl PanelLayoutSubdivision {
 			// Remove empty panel groups
 			children.retain(|child| !matches!(&child.subdivision, PanelLayoutSubdivision::PanelGroup { state, .. } if state.tabs.is_empty()));
 
+			// Remove empty splits (splits that lost all their children after pruning)
+			children.retain(|child| !matches!(&child.subdivision, PanelLayoutSubdivision::Split { children } if children.is_empty()));
+
 			// If a split has exactly one child, replace this subdivision with that child's subdivision
 			if children.len() == 1 {
 				*self = children.remove(0).subdivision;
@@ -470,7 +473,7 @@ impl PanelLayoutSubdivision {
 		}
 	}
 
-	/// Remove a panel group by ID and prune the tree.
+	/// Remove a panel group by ID from the tree. Does not prune.
 	pub fn remove_group(&mut self, target_id: PanelGroupId) {
 		if let PanelLayoutSubdivision::Split { children } = self {
 			children.retain(|child| !matches!(&child.subdivision, PanelLayoutSubdivision::PanelGroup { id, .. } if *id == target_id));

frontend/src/components/window/PanelSubdivision.svelte

@@ -82,12 +82,10 @@
 
 		const abortResize = () => {
 			if (pointerCaptureId) gutter.releasePointerCapture(pointerCaptureId);
+			pointerCaptureId = undefined;
 			removeListeners();
 			activeResizeCleanup = undefined;
 
-			pointerCaptureId = e.pointerId;
-			gutter.setPointerCapture(pointerCaptureId);
-
 			if (gutterResizeRestore !== undefined) {
 				sizeOverrides = { ...sizeOverrides, [nextIndex]: gutterResizeRestore[0], [prevIndex]: gutterResizeRestore[1] };
 				gutterResizeRestore = undefined;