enforce log-file strictness and centralize log filename parsing

Author: PranjalC100

tools/integration_tests/inactive_stream_timeout/setup_test.go

@@ -33,6 +33,7 @@ import (
 	"github.com/googlecloudplatform/gcsfuse/v3/tools/integration_tests/util/mounting/static_mounting"
 	"github.com/googlecloudplatform/gcsfuse/v3/tools/integration_tests/util/setup"
 	"github.com/googlecloudplatform/gcsfuse/v3/tools/integration_tests/util/test_suite"
+	"github.com/stretchr/testify/require"
 )
 
 const (
@@ -93,9 +94,7 @@ func hasInactiveReaderClosedLogLineInLogFile(t *testing.T, objectName, logFile s
 	expectedMsgSubstring := fmt.Sprintf("Closing reader for object %q due to inactivity.", objectName)
 
 	file, err := os.Open(logFile)
-	if err != nil {
-		return "", fmt.Errorf("failed to open log file: %w", err)
-	}
+	require.NoError(t, err, "failed to open log file")
 	defer file.Close()
 
 	scanner := bufio.NewScanner(file)

tools/integration_tests/util/setup/setup.go

@@ -847,11 +847,19 @@ func OverrideFilePathsInFlagSet(t *test_suite.TestConfig, GCSFuseTempDirPath str
 
 func ParseLogFileFromFlags(flags []string) string {
 	for _, flagStr := range flags {
+		flagStr = strings.ReplaceAll(flagStr, ",", " ")
 		parts := strings.Fields(flagStr)
 		for _, part := range parts {
 			if strings.HasPrefix(part, "--log-file=") {
-				// Get just the filename from the path
-				return path.Base(strings.TrimPrefix(part, "--log-file="))
+				logPath := strings.TrimPrefix(part, "--log-file=")
+				if logPath == "" {
+					continue
+				}
+				fileName := path.Base(logPath)
+				if !strings.HasSuffix(fileName, ".log") {
+					fileName += ".log"
+				}
+				return fileName
 			}
 		}
 	}
@@ -861,14 +869,25 @@ func ParseLogFileFromFlags(flags []string) string {
 func SetUpLogFilePath(flags []string, GKETempDir string, OldGKElogFilePath string, cfg *test_suite.TestConfig) {
 	var logFilePath string
 	parsedLogFileName := ParseLogFileFromFlags(flags)
-	if cfg.GKEMountedDirectory != "" { // GKE path
-		logFilePath = path.Join(GKETempDir, parsedLogFileName) + ".log"
+
+	// Infer log filename directly from the parsed config block.
+	if parsedLogFileName == "" && cfg != nil && len(cfg.Configs) > 0 {
+		parsedLogFileName = ParseLogFileFromFlags(cfg.Configs[0].Flags)
+	}
+
+	// Default logFile name.
+	if parsedLogFileName == "" {
+		parsedLogFileName = "gcsfuse-tmp.log"
+	}
+
+	if cfg != nil && cfg.GKEMountedDirectory != "" { // GKE path
+		logFilePath = path.Join(GKETempDir, parsedLogFileName)
 		if ConfigFile() == "" {
 			// TODO: clean this up when GKE test migration completes.
 			logFilePath = OldGKElogFilePath
 		}
 	} else {
-		logFilePath = path.Join(TestDir(), GKETempDir, parsedLogFileName) + ".log"
+		logFilePath = path.Join(TestDir(), GKETempDir, parsedLogFileName)
 	}
 	cfg.LogFile = logFilePath
 	SetLogFile(logFilePath)