Skip to content

Commit e9b43b7

Browse files
committed
4byte pk
1 parent f39048e commit e9b43b7

File tree

3 files changed

+13
-12
lines changed

3 files changed

+13
-12
lines changed

v2/sourcedb-to-spanner/src/test/java/com/google/cloud/teleport/v2/templates/MySQLDataTypesIT.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -392,7 +392,6 @@ private Map<String, List<Map<String, Object>>> getExpectedData() {
392392
"varbinary_to_string", "7835383030", "fffffffffffffffffffffffffffffffff...", "NULL"));
393393
expectedData.put(
394394
"varchar", createRows("varchar", "abc", repeatString("a", 33) + "...", "NULL"));
395-
expectedData.put("varchar_utf8mb4", createRows("varchar_utf8mb4", "😊"));
396395
expectedData.put("year", createRows("year", "2022", "1901", "2155", "NULL"));
397396
expectedData.put("set", createRows("set", "v1,v2", "NULL"));
398397
expectedData.put(
@@ -421,6 +420,7 @@ private Map<String, List<Map<String, Object>>> getExpectedData() {
421420
expectedData.put("tiny_blob_pk", createRows("tiny_blob_pk", "AA==", "gAAAAAAAAAA="));
422421
expectedData.put("char_pk", createRows("char_pk", "AA==", "gAAAAAAAAAA="));
423422
expectedData.put("varchar_pk", createRows("varchar_pk", "AA==", "gAAAAAAAAAA="));
423+
expectedData.put("varchar_utf8mb4_pk", createRows("varchar_utf8mb4_pk", "😊"));
424424
expectedData.put("tiny_text_pk", createRows("tiny_text_pk", "AA==", "gAAAAAAAAAA="));
425425
expectedData.put(
426426
"date_time_pk",

v2/sourcedb-to-spanner/src/test/resources/DataTypesIT/mysql-data-types.sql

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,15 +1,11 @@
11
SET GLOBAL max_connections = 300;
2+
SET NAMES utf8mb4;
23

34
CREATE TABLE `varchar_table` (
45
`id` INT PRIMARY KEY,
56
`varchar_col` VARCHAR(21000) CHARACTER SET utf8 DEFAULT NULL
67
);
78

8-
CREATE TABLE `varchar_utf8mb4_table` (
9-
`id` INT PRIMARY KEY AUTO_INCREMENT,
10-
`varchar_utf8mb4_col` VARCHAR(255) CHARACTER SET utf8mb4 DEFAULT NULL
11-
);
12-
139
CREATE TABLE `tinyint_table` (
1410
`id` INT PRIMARY KEY,
1511
`tinyint_col` TINYINT DEFAULT NULL
@@ -460,6 +456,11 @@ CREATE TABLE varchar_pk_table (
460456
varchar_pk_col VARCHAR(20) NOT NULL
461457
) CHARACTER SET utf8mb3 COLLATE utf8mb3_general_ci;
462458

459+
CREATE TABLE varchar_utf8mb4_pk_table (
460+
id VARCHAR(20) PRIMARY KEY,
461+
varchar_utf8mb4_pk_col VARCHAR(20) NOT NULL
462+
) CHARACTER SET utf8mb4 COLLATE utf8mb4_general_ci;
463+
463464
CREATE TABLE tiny_text_pk_table (
464465
id TINYTEXT,
465466
tiny_text_pk_col TINYTEXT NOT NULL,
@@ -722,7 +723,6 @@ INSERT INTO `varbinary_to_string_table` (`varbinary_to_string_col`) VALUES (REPE
722723
INSERT INTO `varchar_table` (`varchar_col`) VALUES ('abc');
723724
INSERT INTO `varchar_table` (`varchar_col`) VALUES (REPEAT('a', 21000));
724725

725-
INSERT INTO `varchar_utf8mb4_table` (`varchar_utf8mb4_col`) VALUES ('😊');
726726
INSERT INTO `year_table` (`year_col`) VALUES (2022);
727727
INSERT INTO `year_table` (`year_col`) VALUES (1901);
728728
INSERT INTO `year_table` (`year_col`) VALUES (2155);
@@ -744,6 +744,7 @@ INSERT INTO `varbinary_pk_table` (`id`, `varbinary_pk_col`) VALUES (FROM_BASE64(
744744
INSERT INTO `tiny_blob_pk_table` (`id`, `tiny_blob_pk_col`) VALUES (FROM_BASE64('AA=='), FROM_BASE64('AA==')), (FROM_BASE64('gAAAAAAAAAA='), FROM_BASE64('gAAAAAAAAAA='));
745745
INSERT INTO `char_pk_table` (`id`, `char_pk_col`) VALUES ('AA==', 'AA=='), ('gAAAAAAAAAA=', 'gAAAAAAAAAA=');
746746
INSERT INTO `varchar_pk_table` (`id`, `varchar_pk_col`) VALUES ('AA==', 'AA=='), ('gAAAAAAAAAA=', 'gAAAAAAAAAA=');
747+
INSERT INTO `varchar_utf8mb4_pk_table` (`id`, `varchar_utf8mb4_pk_col`) VALUES ('😊', '😊');
747748
INSERT INTO `tiny_text_pk_table` (`id`, `tiny_text_pk_col`) VALUES ('AA==', 'AA=='), ('gAAAAAAAAAA=', 'gAAAAAAAAAA=');
748749
INSERT INTO `date_time_pk_table` (`id`, `date_time_pk_col`) VALUES ('1000-01-01 00:00:00', '1000-01-01 00:00:00'), ('1000-01-01 00:00:01', '1000-01-01 00:00:01'),
749750
('2001-01-01 00:01:54.123456', '2001-01-01 00:01:54.123456'),

v2/sourcedb-to-spanner/src/test/resources/DataTypesIT/mysql-spanner-schema.sql

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -366,11 +366,6 @@ CREATE TABLE IF NOT EXISTS varchar_table (
366366
varchar_col STRING(21000),
367367
) PRIMARY KEY(id);
368368

369-
CREATE TABLE IF NOT EXISTS varchar_utf8mb4_table (
370-
id INT64 NOT NULL,
371-
varchar_utf8mb4_col STRING(255),
372-
) PRIMARY KEY(id);
373-
374369
CREATE TABLE IF NOT EXISTS year_table (
375370
id INT64 NOT NULL,
376371
year_col STRING(MAX),
@@ -502,6 +497,11 @@ CREATE TABLE IF NOT EXISTS varchar_pk_table (
502497
varchar_pk_col STRING(20) NOT NULL,
503498
) PRIMARY KEY(id);
504499

500+
CREATE TABLE IF NOT EXISTS varchar_utf8mb4_pk_table (
501+
id STRING(20) NOT NULL,
502+
varchar_utf8mb4_pk_col STRING(20) NOT NULL,
503+
) PRIMARY KEY(id);
504+
505505
CREATE TABLE IF NOT EXISTS tiny_text_pk_table (
506506
id STRING(20) NOT NULL,
507507
tiny_text_pk_col STRING(20) NOT NULL,

0 commit comments

Comments
 (0)