feat(configuration)!: require sequence format for version strategies

- remove custom VersionStrategies YAML converter
- stop treating VersionStrategies[] as a supported overrideconfig scalar type
- require YAML sequence/array format for strategies values
- update configuration and app tests to match array-only behavior

BREAKING CHANGE: scalar strategies format (e.g. "strategies: A, B") is no longer supported; use YAML sequence/array syntax instead.

Author: arturcic

src/GitVersion.App.Tests/ArgumentParserTests.cs

@@ -530,13 +530,6 @@ private static IEnumerable<TestCaseData> OverrideConfigWithSingleOptionTestData(
                 UpdateBuildNumber = true
             }
         );
-        yield return new TestCaseData(
-            "strategies=[\"None\",\"Mainline\"]",
-            new GitVersionConfiguration
-            {
-                VersionStrategies = [VersionStrategies.None, VersionStrategies.Mainline]
-            }
-        );
     }
 
     [TestCaseSource(nameof(OverrideConfigWithMultipleOptionsTestData))]

src/GitVersion.App/OverrideConfigurationOptionParser.cs

@@ -1,5 +1,4 @@
 using GitVersion.Configuration;
-using GitVersion.VersionCalculation;
 
 namespace GitVersion;
 
@@ -37,7 +36,7 @@ internal class OverrideConfigurationOptionParser
     /// is supported as a part of command line '/overrideconfig' option.
     /// </summary>
     /// <param name="propertyType">Type we want to check.</param>
-    /// <returns>True, if type is supported.</returns>
+    /// <returns>True, if the type is supported.</returns>
     /// <remarks>Only simple types are supported</remarks>
     private static bool IsSupportedPropertyType(Type propertyType)
     {
@@ -46,8 +45,7 @@ private static bool IsSupportedPropertyType(Type propertyType)
         return unwrappedType == typeof(string)
                || unwrappedType.IsEnum
                || unwrappedType == typeof(int)
-               || unwrappedType == typeof(bool)
-               || unwrappedType == typeof(VersionStrategies[]);
+               || unwrappedType == typeof(bool);
     }
 
     internal void SetValue(string key, string value) => overrideConfiguration[key] = QuotedStringHelpers.UnquoteText(value);

src/GitVersion.Configuration.Tests/Configuration/IgnoreConfigurationTests.cs

@@ -74,9 +74,9 @@ public void WhenBadDateFormatShouldFail()
     }
 
     [Test]
-    public void ShouldSupportScalarVersionStrategiesOverrideFormat()
+    public void ShouldSupportArrayVersionStrategiesFormat()
     {
-        const string yaml = "strategies: ConfiguredNextVersion, TaggedCommit";
+        const string yaml = "strategies: [ConfiguredNextVersion, TaggedCommit]";
 
         var configuration = serializer.ReadConfiguration(yaml);
 

src/GitVersion.Configuration/ConfigurationSerializer.cs

@@ -10,7 +10,6 @@ internal class ConfigurationSerializer : IConfigurationSerializer
     {
         PropertyNamingPolicy = HyphenatedJsonNamingPolicy.Instance,
         DefaultIgnoreCondition = YamlIgnoreCondition.WhenWritingNull,
-        Converters = [VersionStrategiesConverter.Instance]
     };
 
     public T Deserialize<T>(string input)
@@ -27,13 +26,9 @@ public T Deserialize<T>(string input)
             {
                 return (T)(object)YamlSerializer.Deserialize<GitVersionConfiguration>(input, GeneratedContext)!;
             }
-            catch (YamlException)
+            catch (Exception exception) when (exception is not YamlException)
             {
-                throw;
-            }
-            catch (Exception exception)
-            {
-                throw new YamlException(exception.Message);
+                throw new YamlException(exception.Message, exception);
             }
         }
 

src/GitVersion.Configuration/ConfigurationYamlContext.cs

@@ -3,11 +3,9 @@
 
 namespace GitVersion.Configuration;
 
-[YamlSourceGenerationOptions(
-    DefaultIgnoreCondition = YamlIgnoreCondition.WhenWritingNull,
-    Converters = [typeof(VersionStrategiesConverter)])]
+[YamlSourceGenerationOptions(DefaultIgnoreCondition = YamlIgnoreCondition.WhenWritingNull)]
 [YamlSerializable(typeof(GitVersionConfiguration))]
 [YamlSerializable(typeof(BranchConfiguration))]
 [YamlSerializable(typeof(PreventIncrementConfiguration))]
 [YamlSerializable(typeof(IgnoreConfiguration))]
-internal partial class ConfigurationYamlContext : YamlSerializerContext;
+internal partial class ConfigurationYamlContext : YamlSerializerContext;