Skip to content

Commit e318676

Browse files
committed
fix: update defaultComponents test after optional overrides extraction
1 parent d03d7f9 commit e318676

File tree

1 file changed

+2
-30
lines changed

1 file changed

+2
-30
lines changed
Lines changed: 2 additions & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,11 @@
11
import { DEFAULT_COMPONENTS } from '../defaultComponents';
22

3-
// Optional component keys that are intentionally undefined (no default implementation)
4-
const OPTIONAL_KEYS = new Set([
5-
'AttachmentPickerIOSSelectMorePhotos',
6-
'ChatLoadingIndicator',
7-
'CreatePollContent',
8-
'MessageActions',
9-
'Input',
10-
'ListHeaderComponent',
11-
'MessageContentBottomView',
12-
'MessageContentLeadingView',
13-
'MessageContentTopView',
14-
'MessageContentTrailingView',
15-
'MessageLocation',
16-
'MessageSpacer',
17-
'MessageText',
18-
'PollContent',
19-
]);
20-
213
describe('DEFAULT_COMPONENTS', () => {
22-
it('should have all required values defined', () => {
4+
it('should have all values defined', () => {
235
const entries = Object.entries(DEFAULT_COMPONENTS);
246
expect(entries.length).toBeGreaterThan(50);
257

26-
const unexpectedUndefined = entries.filter(
27-
([key, value]) => value === undefined && !OPTIONAL_KEYS.has(key),
28-
);
8+
const unexpectedUndefined = entries.filter(([, value]) => value === undefined);
299
if (unexpectedUndefined.length > 0) {
3010
console.log(
3111
'Unexpectedly undefined keys:',
@@ -34,12 +14,4 @@ describe('DEFAULT_COMPONENTS', () => {
3414
}
3515
expect(unexpectedUndefined).toEqual([]);
3616
});
37-
38-
it('optional keys should be explicitly listed', () => {
39-
const entries = Object.entries(DEFAULT_COMPONENTS);
40-
const actualUndefined = new Set(
41-
entries.filter(([, v]) => v === undefined || v === null).map(([k]) => k),
42-
);
43-
expect(actualUndefined).toEqual(OPTIONAL_KEYS);
44-
});
4517
});

0 commit comments

Comments
 (0)