Skip to content

Commit 1508613

Browse files
committed
Fix empty metadata string values
1 parent 43fb090 commit 1508613

1 file changed

Lines changed: 13 additions & 8 deletions

File tree

.internal/pre_commit_tools/metadata_utils.py

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -37,20 +37,21 @@ def get_value_error_message(self, data: Any) -> str:
3737
raise NotImplementedError
3838

3939

40+
@dataclass
4041
class FieldStr(Field):
4142
allow_empty: bool = False
4243

4344
_expected_type = str
4445

4546
def verify_type(self, data: Any) -> bool:
46-
if self.allow_empty:
47-
return True
48-
else:
49-
return type(data) is str
47+
return type(data) is str
5048

5149
def verify_value(self, data: str) -> bool:
5250
# verify data is not empty
53-
return bool(data)
51+
if self.allow_empty:
52+
return True
53+
else:
54+
return bool(data)
5455

5556

5657
@dataclass
@@ -130,10 +131,14 @@ def _generate_empty_str(*args, **kwargs) -> str:
130131
),
131132
FieldList("level", _generate_empty_list, ["basic", "advanced", "demos"]),
132133
# New fields: str
133-
FieldStr("id", _generate_empty_str), # todo: change generate_default_value
134-
FieldStr("thumbnail", _generate_empty_str), # todo: add `validate file exists`
135134
FieldStr(
136-
"preview-file/code", _generate_empty_str
135+
"id", _generate_empty_str, allow_empty=True
136+
), # todo: change generate_default_value
137+
FieldStr(
138+
"thumbnail", _generate_empty_str, allow_empty=True
139+
), # todo: add `validate file exists`
140+
FieldStr(
141+
"preview-file/code", _generate_empty_str, allow_empty=True
137142
), # todo: add `validate file exists`
138143
# New fields: lists
139144
FieldList(

0 commit comments

Comments
 (0)