fix: resolve test state pollution and update editor types

Author: Catharacta

src/mainview/editor/EditorManager.ts

@@ -17,6 +17,18 @@ export class EditorManager {
     private static instance: Editor | null = null;
     private static autoSaveTimeout: any = null;
 
+    /**
+     * Resets the editor instance and global state reference.
+     * Useful for testing and clean teardown.
+     */
+    static reset(): void {
+        if (this.instance) {
+            this.instance.destroy();
+            this.instance = null;
+        }
+        state.editor = null;
+    }
+
     /**
      * Initializes the editor in the specified element.
      */

src/mainview/state/workspace.ts

@@ -14,7 +14,7 @@ export const state = {
     expandedPaths: new Set<string>(), // Paths of folders currently expanded
     openTabs: new Map<string, TabState>(),
     untitledCount: 0,
-    editor: null as unknown as Editor,
+    editor: null as Editor | null,
     activeSidebarTab: 'explorer' as 'explorer' | 'search',
     searchResults: [] as any[],
     editorSettings: {

tests/manager-editor.test.ts

@@ -1,4 +1,4 @@
-import { expect, test, describe, beforeEach, spyOn, mock } from "bun:test";
+import { expect, test, describe, beforeEach, afterEach, spyOn, mock } from "bun:test";
 import "./setup";
 import { EditorManager } from "../src/mainview/editor/EditorManager";
 import { state } from "../src/mainview/state/workspace";
@@ -53,24 +53,22 @@ describe("EditorManager", () => {
 
     test("init should create editor instance and bind events", async () => {
         const editorEl = document.getElementById("editor") as HTMLElement;
-        EditorManager.init(editorEl);
+        const editor = EditorManager.init(editorEl);
 
-        expect(state.editor).toBeDefined();
+        expect(state.editor).toBe(editor);
         expect(state.editor instanceof MockEditor).toBe(true);
-        
-        const autoSaveToggle = document.getElementById("autoSaveToggle") as HTMLInputElement;
-        expect(autoSaveToggle).toBeDefined();
+        expect(state.editor!.options.element).toBe(editorEl);
     });
 
     test("getHTML/setContent should work", async () => {
         const editorEl = document.getElementById("editor") as HTMLElement;
         EditorManager.init(editorEl);
 
         const testHtml = "<h1>Test</h1>";
-        (state.editor.commands.setContent as any).mockClear();
+        (state.editor!.commands.setContent as any).mockClear();
 
         await EditorManager.setContent(testHtml);
-        expect(state.editor.commands.setContent).toHaveBeenCalledWith(testHtml);
+        expect(state.editor!.commands.setContent).toHaveBeenCalledWith(testHtml);
 
         const content = EditorManager.getHTML();
         expect(content).toBe("<p>mock content</p>");
@@ -85,7 +83,7 @@ describe("EditorManager", () => {
         state.openTabs.set("test.md", { filePath: "test.md", isDirty: false });
 
         // Trigger update
-        (EditorManager as any).handleUpdate(state.editor);
+        (EditorManager as any).handleUpdate(state.editor!);
 
         // Wait for auto-save timeout (2000ms in EditorManager)
         return new Promise<void>((resolve) => {

tests/performance.test.ts

@@ -3,6 +3,7 @@ import { describe, it, expect, mock, beforeEach, spyOn } from "bun:test";
 
 import { Editor } from "@tiptap/core";
 import { setEditorContent } from "../src/mainview/editor";
+import { EditorManager } from "../src/mainview/editor/EditorManager";
 import { state } from "../src/mainview/state/workspace";
 
 // Mock the editor instance
@@ -17,6 +18,7 @@ const mockEditor = {
 
 describe("Performance Optimization Tests", () => {
     beforeEach(() => {
+        EditorManager.reset();
         state.editor = mockEditor;
     });