feat: type installSource as enum and throw on missing native properties

Author: AlshehriAli0

bun.lock

@@ -13,7 +13,7 @@
     "expo-status-bar": "~55.0.4",
     "react": "19.2.0",
     "react-native": "0.83.2",
-    "react-native-nitro-modules": ">=0.35.0",
+    "react-native-nitro-modules": "0.35.0",
     "react-native-nitro-version-check": "*",
     "react-native-version-check": "^3.5.0"
   },

example/package.json

@@ -16,28 +16,33 @@ class HybridVersionCheck : HybridVersionCheckSpec() {
         private val packageInfo = context?.packageManager?.getPackageInfo(context.packageName, 0)
     }
 
-    public override val version = packageInfo?.versionName ?: "unknown"
+    public override val version = packageInfo?.versionName
+        ?: error("[VersionCheck] Failed to read 'version' (versionName) from PackageInfo")
 
     public override val buildNumber = if (android.os.Build.VERSION.SDK_INT >= 28) {
-        if (packageInfo?.longVersionCode != null) packageInfo.longVersionCode.toString() else "unknown"
+        packageInfo?.longVersionCode?.toString()
+            ?: error("[VersionCheck] Failed to read 'buildNumber' (longVersionCode) from PackageInfo")
     } else {
         @Suppress("DEPRECATION")
-        if (packageInfo?.versionCode != null) packageInfo.versionCode.toString() else "unknown"
+        packageInfo?.versionCode?.toString()
+            ?: error("[VersionCheck] Failed to read 'buildNumber' (versionCode) from PackageInfo")
     }
 
-    public override val packageName = packageInfo?.packageName ?: "unknown"
-    public override val installSource: String? = run {
+    public override val packageName = packageInfo?.packageName
+        ?: error("[VersionCheck] Failed to read 'packageName' from PackageInfo")
+    public override val installSource: InstallSource? = run {
         val installer = if (android.os.Build.VERSION.SDK_INT >= 30) {
             context?.packageManager?.getInstallSourceInfo(context.packageName)?.installingPackageName
         } else {
             @Suppress("DEPRECATION")
             context?.packageManager?.getInstallerPackageName(context.packageName)
         }
-        if (installer != null) "playstore" else null
+        if (installer != null) InstallSource.PLAYSTORE else null
     }
 
     override fun getCountry(): String {
-        return java.util.Locale.getDefault().country ?: "unknown"
+        return java.util.Locale.getDefault().country
+            ?: error("[VersionCheck] Failed to determine device 'country' (Locale.getDefault().country)")
     }
 
     override fun getStoreUrl(countryCode: String?): Promise<String> {

package/android/src/main/java/com/margelo/nitro/nitroversioncheck/HybridVersionCheck.kt

@@ -9,25 +9,34 @@ class HybridVersionCheck: HybridVersionCheckSpec {
         return URLSession(configuration: config)
     }()
 
-    var version = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String ?? "unknown"
-    var buildNumber = Bundle.main.infoDictionary?["CFBundleVersion"] as? String ?? "unknown"
-    var packageName = Bundle.main.infoDictionary?["CFBundleIdentifier"] as? String ?? "unknown"
-    var installSource: String? = {
+    var version = Bundle.main.infoDictionary?["CFBundleShortVersionString"] as? String
+        ?? { fatalError("[VersionCheck] Failed to read 'version' (CFBundleShortVersionString) from Info.plist") }()
+    var buildNumber = Bundle.main.infoDictionary?["CFBundleVersion"] as? String
+        ?? { fatalError("[VersionCheck] Failed to read 'buildNumber' (CFBundleVersion) from Info.plist") }()
+    var packageName = Bundle.main.infoDictionary?["CFBundleIdentifier"] as? String
+        ?? { fatalError("[VersionCheck] Failed to read 'packageName' (CFBundleIdentifier) from Info.plist") }()
+    var installSource: InstallSource? = {
         guard let receiptURL = Bundle.main.appStoreReceiptURL,
               FileManager.default.fileExists(atPath: receiptURL.path) else {
             return nil
         }
         if receiptURL.lastPathComponent == "sandboxReceipt" {
-            return "testflight"
+            return .testflight
         }
-        return "appstore"
+        return .appstore
     }()
 
     func getCountry() throws -> String {
         if #available(iOS 16, *) {
-            return Locale.current.region?.identifier ?? "unknown"
+            guard let region = Locale.current.region?.identifier else {
+                throw NSError(domain: "VersionCheck", code: 4, userInfo: [NSLocalizedDescriptionKey: "Failed to determine device 'country' (Locale.current.region)"])
+            }
+            return region
+        }
+        guard let regionCode = Locale.current.regionCode else {
+            throw NSError(domain: "VersionCheck", code: 4, userInfo: [NSLocalizedDescriptionKey: "Failed to determine device 'country' (Locale.current.regionCode)"])
         }
-        return Locale.current.regionCode ?? "unknown"
+        return regionCode
     }
 
     func getStoreUrl(countryCode: String? = nil) throws -> Promise<String> {