🐛 Bug: Missing sub declarations in ServerCheck.pm

[hawkeye4iot]

CSF › Version

v15.10

CSF › Release

Stable

System › OS

Linux

System › Distro & Version

Ubuntu 24.04

Control Panel › Name

Generic (None)

Priority

High

Issue Description

File: src/ConfigServer/ServerCheck.pm
CSF Version: v15.10
Severity: Critical : CSF cannot start at all (csf -ra, csf -v, etc. all fail)

Error

Unmatched right curly bracket at /usr/local/csf/lib/ConfigServer/ServerCheck.pm line 194, at end of line
syntax error at /usr/local/csf/lib/ConfigServer/ServerCheck.pm line 194, near "}"
Compilation failed in require at /usr/sbin/csf line 43.

Root Cause

Two subroutine declarations (sub report and sub servercheck) are missing from the file. The function bodies are present, but the sub name { opening lines were accidentally removed , likely during a refactor or merge.

Steps To Reproduce

Try a fresh install on Ubuntu 24.04 Lts

1. git clone https://github.com/Aetherinox/csf-firewall.git
2. cd csf-firewall/src
3. sudo bash install.sh

Logs › Lfd

No response

Config › csf.conf

No response

Screenshots

No response

[hawkeye4iot]

BUG :

Two subroutine declarations ('sub report' and 'sub servercheck') are missing from 'ServerCheck.pm'. The function bodies are present with all their logic intact, but the 'sub name {' opening lines were accidentally removed , these were likely during a refactor or merge in the upstream repository.

Perl sees the function body code at module level (outside any 'sub'), encounters the closing '}' braces, and throws a compilation error since there's no matching opening brace.

Problematic Lines :

# /usr/sbin/csf, line 6215:
my $output = ConfigServer::ServerCheck::report();

# /usr/local/csf/lib/ConfigServer/DisplayUI.pm, line 1139:
print ConfigServer::ServerCheck::report($FORM{verbose});

Broken Code (lines 71-196)

The function body starts at line 73 (after 'my $ipv4reg') but has no 'sub report {' declaration:

# Line 71
my $ipv4reg = ConfigServer::Config->ipv4reg;
# Line 72 — MISSING: sub report {
my $ipv6reg = ConfigServer::Config->ipv6reg;    # <-- orphan code at module level
    if ( defined $ENV{WEBMIN_VAR} and defined $ENV{WEBMIN_CONFIG} )
    {
        $config{GENERIC} = 1;
        $config{DIRECTADMIN} = 0;
    }

# ... 120+ lines of function body ...
# ... environment detection, process scanning, report generation ...

    # Line 160-164
    &startoutput;
    &firewallcheck;
    &servercheck;                               # <-- calls the other missing sub
    &sshtelnetcheck;

    # ... more logic ...

    &servicescheck;
    &endoutput;

    return $output;
}                                               # <-- Line 196: orphan closing brace
                                                #     Perl error: "Unmatched right curly bracket"

Fixed Code

Insert 'sub report {' between line 71 and line 72:

# Line 71
my $ipv4reg = ConfigServer::Config->ipv4reg;

sub report {                                    # <-- ADD THIS LINE

my $ipv6reg = ConfigServer::Config->ipv6reg;
    if ( defined $ENV{WEBMIN_VAR} and defined $ENV{WEBMIN_CONFIG} )
    {
        $config{GENERIC} = 1;
        $config{DIRECTADMIN} = 0;
    }

    # ... (all existing code unchanged) ...

    return $output;
}

Command to Fix

sudo sed -i '72i\sub report {' /usr/local/csf/lib/ConfigServer/ServerCheck.pm

---

Missing 'sub servercheck {'

Problematic Line

# Inside sub report (ServerCheck.pm, line 164 after Bug 1 fix):
&servercheck;

Broken Code ( Line 740- 1035)

The function body starts at line 742 but has no 'sub servercheck {' declaration:

# Line 739-740 — end of sub services_disable_automatic

        push @failed, $service;
    }
}

    return (\@disabled, \@failed);
}

# Line 741 — MISSING: sub servercheck {
my $status = 0; # <-- orphan code at module level

  my ($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size,
       $atime,$mtime,$ctime,$blksize,$blocks) = stat("/tmp");
   my $pmode = sprintf "%03o", $mode & oct("07777");

   $status = 0;
   if ($pmode != 1777) { $status = 1 }
   &addline($status,"Check /tmp permissions",
            "/tmp should be chmod 1777");

# ... 290+ lines of server checks ...
# ... /tmp permissions, /var/tmp, MySQL, SSH, kernel, etc. ...

**# Line 1031-1035**

                if ($conf > 0) { $status = 1 }
                &addline($status,"CloudLinux Disable ptrace", "...");
            }
        }
    }
    return;
}                          
```                     # <-- Line 1035: orphan closing brace
                                                #     Perl error: "Unmatched right curly bracket"

# #
#   WHM > Check
# #

sub whmcheck
{

### Fixed Code

Insert 'sub servercheck {' between line 740 and line 741:

    push @failed, $service;
}

}

return (\@disabled, \@failed);

}

sub servercheck { # <-- ADD THIS LINE

my $status = 0;

my ($dev,$ino,$mode,$nlink,$uid,$gid,$rdev,$size,
    $atime,$mtime,$ctime,$blksize,$blocks) = stat("/tmp");
my $pmode = sprintf "%03o", $mode & oct("07777");

# ... (all existing code unchanged) ...

return;

}

### Command to fix 

`sudo sed -i '741i\sub servercheck {' /usr/local/csf/lib/ConfigServer/ServerCheck.pm`


### Verification After Fix 

**# 1. Perl syntax check**
`$ sudo perl -c /usr/local/csf/lib/ConfigServer/ServerCheck.pm`
/usr/local/csf/lib/ConfigServer/ServerCheck.pm syntax OK


###  Subroutine Structure Map (After Fix)

The complete subroutine structure of 'ServerCheck.pm' after the fix:


'''
Line    Declaration                     Closing Brace
────    ───────────                     ─────────────
73      sub report {                    Line 196
202     sub startoutput {               Line 210
216     sub addline {                   Line 235
241     sub addtitle {                  Line 268
274     sub endoutput {                 Line 325
331     sub firewallcheck {             Line 475
487     sub servicescheck {             Line 604
615     sub _run_quiet_rc {             Line 632
644     sub services_disable_automatic { Line 740
741     sub servercheck {               Line 1035
1041    sub whmcheck {                  Line 1404
1408    sub dacheck {                   Line 1492
1496    sub mailcheck {                 Line 1738
1742    sub phpcheck {                  Line 1906
1910    sub apachecheck {               Line 2086
2090    sub sshtelnetcheck {            Line 2173
2177    sub servicescheck {             Line 2226
2230    sub getportinfo {               Line 2247
'''


### **Steps to Reproduce**

### On a Fresh Server

# 1. Clone the repository
git clone https://github.com/Aetherinox/csf-firewall.git
cd csf-firewall/src

# 2. Install CSF
sudo bash install.sh

# 3. Run any CSF command  and all will fail
sudo csf -v
# ERROR: Unmatched right curly bracket at ServerCheck.pm line 194

# 4. Verify bug is in the source
perl -c src/ConfigServer/ServerCheck.pm
# Same compilation error

# 5. Confirm source matches installed file
diff src/ConfigServer/ServerCheck.pm /usr/local/csf/lib/ConfigServer/ServerCheck.pm
# No difference  cause  bug is in the repository


**Verify All CSF Commands Fail**

sudo csf -v # fails
sudo csf -ra # fails
sudo csf -s # fails
sudo csf -x # fails
sudo csf -e # fails

# Every csf command fails — firewall is completely non-functional