Correction when deleting GitLab groups: that array_key_exists_i() check should be looking for falsehood.

Adambean · AdamReece-WebBox · commit 4974381493d9 · 2025-10-27T10:56:01.000Z
diff --git a/src/LdapSyncCommand.php b/src/LdapSyncCommand.php
@@ -1744,7 +1744,7 @@ private function deployGitlabUsersAndGroups(array $config, string $gitlabInstanc
                 continue;
             }
 
-            if ($this->array_key_exists_i($gitlabGroupName, $ldapGroupsSafe)) {
+            if (!$this->array_key_exists_i($gitlabGroupName, $ldapGroupsSafe)) {
                 continue;
             }
             $ldapGroupMembers = $ldapGroupsSafe[$gitlabGroupName];

Original file line number	Diff line number	Diff line change
`@@ -1744,7 +1744,7 @@ private function deployGitlabUsersAndGroups(array $config, string $gitlabInstanc`
`1744`	`1744`	`continue;`
`1745`	`1745`	`}`
`1746`	`1746`
`1747`		`- if ($this->array_key_exists_i($gitlabGroupName, $ldapGroupsSafe)) {`
	`1747`	`+ if (!$this->array_key_exists_i($gitlabGroupName, $ldapGroupsSafe)) {`
`1748`	`1748`	`continue;`
`1749`	`1749`	`}`
`1750`	`1750`	`$ldapGroupMembers = $ldapGroupsSafe[$gitlabGroupName];`